-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove a couple of awaitsfix in EsqlActionIT #100391
Conversation
Pinging @elastic/es-ql (Team:QL) |
Pinging @elastic/elasticsearch-esql (:Query Languages/ES|QL) |
Note: currently the complete EsqlActionIT test is marked awaits fix, but the test will be reenabled soon by #100370. |
Argh! :-( loopy testing has now hit this:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
I have a theory and I will look into this. |
closing in favour of splitting these two Awaits fixes, since one of them is stable, the other is not yet. See #100604 |
This commit removes a couple of awaits fixes in EsqlActionIT that are no longer needed - previous changes have resolved the underlying issue and the test scenarios now run successfully consistently.