Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] More checks and tests for parsing Inference processor config #100335

Merged
merged 2 commits into from
Oct 6, 2023

Conversation

davidkyle
Copy link
Member

Following on from #100205 this PR adds more tests and checks for corner cases when parsing the configuration. Also updates the docs with missing details.

@davidkyle davidkyle added >test Issues or PRs that are addressing/adding tests :ml Machine learning v8.11.0 v8.12.0 labels Oct 5, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2023

Documentation preview:

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/ml-core (Team:ML)

@elasticsearchmachine elasticsearchmachine added the Team:ML Meta label for the ML team label Oct 5, 2023
Copy link
Contributor

@jonathan-buttner jonathan-buttner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a question and some readability suggestions.

@davidkyle
Copy link
Member Author

@elasticsearchmachine run elasticsearch-ci/part-2

@davidkyle davidkyle merged commit 6cde0df into elastic:main Oct 6, 2023
12 checks passed
davidkyle added a commit to davidkyle/elasticsearch that referenced this pull request Oct 6, 2023
…astic#100335)

Following on from elastic#100205 this PR adds more tests and checks 
for corner cases when parsing the configuration.
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.11

elasticsearchmachine pushed a commit that referenced this pull request Oct 6, 2023
…00335) (#100416)

Following on from #100205 this PR adds more tests and checks 
for corner cases when parsing the configuration.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:ml Machine learning Team:ML Meta label for the ML team >test Issues or PRs that are addressing/adding tests v8.11.0 v8.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants