Convert core xpack rest tests to new test framework #100301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mark-vieira
added
>non-issue
:Delivery/Build
|
Pinging @elastic/es-delivery (Team:Delivery) |
mark-vieira
added a commit
to mark-vieira/elasticsearch
that referenced
this pull request
Oct 4, 2023
💔 Backport failed
You can use sqren/backport to manually backport by running |
mark-vieira
added a commit
to mark-vieira/elasticsearch
that referenced
this pull request
Oct 4, 2023
# Conflicts: # test/test-clusters/src/main/java/org/elasticsearch/test/cluster/FeatureFlag.java # x-pack/plugin/build.gradle
elasticsearchmachine
pushed a commit
that referenced
this pull request
Oct 4, 2023
elasticsearchmachine
pushed a commit
that referenced
this pull request
Oct 4, 2023
droberts195
reviewed
Oct 5, 2023
| @@ -15,7 +15,8 @@ | |||
| * to indicate that this feature is required and should be enabled when appropriate. | |||
| */ | |||
| public enum FeatureFlag { | |||
| TIME_SERIES_MODE("es.index_mode_feature_flag_registered=true", Version.fromString("8.0.0"), null); | |||
| TIME_SERIES_MODE("es.index_mode_feature_flag_registered=true", Version.fromString("8.0.0"), null), | |||
| INFERENCE_RESCORER("es.inference_rescorer_feature_flag_enabled", Version.fromString("8.10.0"), null); | |||
There was a problem hiding this comment.
Is this missing an =true? This PR seems to have caused #100362, so I think there's something different to before about the way the feature flag is set in release builds.
There was a problem hiding this comment.
I think you're right. I'll get this fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This converts the x-pack core YAML tests to using the new test clusters testing framework.
Fixes #95334