Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Transform] Add an assertion to the testTransformFeatureReset test case #100287

Merged
merged 4 commits into from
Oct 5, 2023

Conversation

przemekwitek
Copy link
Contributor

This PR adds an assertion that verifies that there are no documents in the transform internal indices after feature reset.
If such documents exist, it will render their contents.
Additionally, this PR adds more logging for this test case.

Relates #99292

@przemekwitek przemekwitek added >test Issues or PRs that are addressing/adding tests :ml/Transform Transform labels Oct 4, 2023
@elasticsearchmachine elasticsearchmachine added Team:ML Meta label for the ML team v8.12.0 labels Oct 4, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/ml-core (Team:ML)

Copy link
Contributor

@edsavage edsavage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@przemekwitek przemekwitek force-pushed the feature_reset_assertion branch from 5923ff0 to 8b54455 Compare October 4, 2023 16:13
@przemekwitek przemekwitek merged commit 9984b4f into elastic:main Oct 5, 2023
@przemekwitek przemekwitek deleted the feature_reset_assertion branch October 5, 2023 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:ml/Transform Transform Team:ML Meta label for the ML team >test Issues or PRs that are addressing/adding tests v8.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants