Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Transform] Shutdown the task immediately when force == true #100203

Merged
merged 7 commits into from
Oct 9, 2023

Conversation

przemekwitek
Copy link
Contributor

@przemekwitek przemekwitek commented Oct 3, 2023

It turns out force stopping a transform doesn't always remove the persistent task.

This PR ensures that the persistent task is removed ASAP as opposed to being removed in the listener on a separate thread.

Relates #99292

@przemekwitek przemekwitek changed the title [Transform] Shutdown the task when force==true [Transform] Shutdown the task immediately when force == true Oct 4, 2023
@przemekwitek przemekwitek removed the WIP label Oct 4, 2023
@przemekwitek przemekwitek marked this pull request as ready for review October 4, 2023 10:04
@elasticsearchmachine elasticsearchmachine added the Team:ML Meta label for the ML team label Oct 4, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/ml-core (Team:ML)

@elasticsearchmachine
Copy link
Collaborator

Hi @przemekwitek, I've created a changelog YAML for you.

@przemekwitek
Copy link
Contributor Author

run elasticsearch-ci/part-2

@mattc58 mattc58 added v8.12.0 and removed v8.11.0 labels Oct 4, 2023
@droberts195 droberts195 added v8.10.4 cloud-deploy Publish cloud docker image for Cloud-First-Testing labels Oct 5, 2023
@droberts195
Copy link
Contributor

@elasticmachine run elasticseach-ci/cloud-deploy

@droberts195
Copy link
Contributor

@elasticmachine update branch

@przemekwitek
Copy link
Contributor Author

run elasticsearch-ci/part-2

@przemekwitek
Copy link
Contributor Author

run elasticsearch-ci/part-2

@przemekwitek
Copy link
Contributor Author

run elasticsearch-ci/part-2

@przemekwitek
Copy link
Contributor Author

jenkins test this

4 similar comments
@przemekwitek
Copy link
Contributor Author

jenkins test this

@przemekwitek
Copy link
Contributor Author

jenkins test this

@przemekwitek
Copy link
Contributor Author

jenkins test this

@przemekwitek
Copy link
Contributor Author

jenkins test this

Copy link
Contributor

@droberts195 droberts195 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@przemekwitek przemekwitek merged commit 48e86ad into elastic:main Oct 9, 2023
@przemekwitek przemekwitek deleted the fix_force_stop branch October 9, 2023 08:57
@przemekwitek przemekwitek added the auto-backport Automatically create backport pull requests when merged label Oct 9, 2023
przemekwitek added a commit to przemekwitek/elasticsearch that referenced this pull request Oct 9, 2023
@przemekwitek
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
8.11
8.10

Questions ?

Please refer to the Backport tool documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Automatically create backport pull requests when merged >bug cloud-deploy Publish cloud docker image for Cloud-First-Testing :ml/Transform Transform Team:ML Meta label for the ML team v8.10.4 v8.11.0 v8.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants