Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release ESQL response in IT tests #100176

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Release ESQL response in IT tests #100176

merged 1 commit into from
Oct 3, 2023

Conversation

dnhatn
Copy link
Member

@dnhatn dnhatn commented Oct 3, 2023

Make sure that we close ESQL responses in our IT tests

Closes #100142

@dnhatn dnhatn added >test Issues or PRs that are addressing/adding tests :Analytics/ES|QL AKA ESQL v8.11.0 labels Oct 3, 2023
@dnhatn dnhatn mentioned this pull request Oct 3, 2023
Closed
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-ql (Team:QL)

@elasticsearchmachine elasticsearchmachine added the Team:QL (Deprecated) Meta label for query languages team label Oct 3, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/elasticsearch-esql (:Query Languages/ES|QL)

ChrisHegarty
ChrisHegarty approved these changes Oct 3, 2023
View reviewed changes
Copy link
Contributor

@ChrisHegarty ChrisHegarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ChrisHegarty ChrisHegarty merged commit af65bb9 into elastic:main Oct 3, 2023
@ChrisHegarty
Copy link
Contributor

I went ahead and merged this PR, as it allows to get other parts of the system testing without the need for mutes.

@dnhatn dnhatn deleted the close-resp branch October 3, 2023 14:12
@dnhatn
Copy link
Member Author

dnhatn commented Oct 3, 2023

Thanks, Chris!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisHegarty ChrisHegarty ChrisHegarty approved these changes

Assignees
No one assigned
Labels
:Analytics/ES|QL AKA ESQL Team:QL (Deprecated) Meta label for query languages team >test Issues or PRs that are addressing/adding tests v8.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ESQL: org.elasticsearch.xpack.esql.action.ManyShardsIT.testConcurrentQueries failing
3 participants
@dnhatn @elasticsearchmachine @ChrisHegarty