Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ESQL: Use blockFactory more in aggs #100017

Merged
merged 38 commits into from
Oct 3, 2023
Merged

ESQL: Use blockFactory more in aggs #100017

merged 38 commits into from
Oct 3, 2023

Conversation

ChrisHegarty
Copy link
Contributor

@ChrisHegarty ChrisHegarty commented Sep 28, 2023 •
edited
Loading

This commit updates the hash grouping operator to close input pages, as well as use the block factory for internally created blocks.

Additionally:

  • Adds a MockBlockFactory to help with tracking block creation
  • Eagerly creates the block view of a vector, which helps with tracking since there can be only one block view instance per vector
  • Resolves an issue with Filter Blocks, whereby they previously tried to emit their contents in toString

@ChrisHegarty ChrisHegarty added WIP >refactoring Team:QL (Deprecated) Meta label for query languages team :Analytics/ES|QL AKA ESQL labels Sep 28, 2023
@ChrisHegarty ChrisHegarty removed the WIP label Oct 2, 2023
@ChrisHegarty ChrisHegarty marked this pull request as ready for review October 2, 2023 08:50
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-ql (Team:QL)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/elasticsearch-esql (:Query Languages/ES|QL)

nik9000
nik9000 reviewed Oct 2, 2023
View reviewed changes
...ql/compute/src/main/generated-src/org/elasticsearch/compute/data/LongVectorFixedBuilder.java Outdated Show resolved Hide resolved
...compute/src/main/java/org/elasticsearch/compute/aggregation/blockhash/BytesRefBlockHash.java Outdated Show resolved Hide resolved
x-pack/plugin/esql/compute/src/main/java/org/elasticsearch/compute/operator/Driver.java Outdated Show resolved Hide resolved
x-pack/plugin/esql/compute/src/main/java/org/elasticsearch/compute/operator/Driver.java Outdated Show resolved Hide resolved
...k/plugin/esql/compute/src/test/java/org/elasticsearch/compute/data/BlockAccountingTests.java Show resolved Hide resolved
x-pack/plugin/esql/compute/src/test/java/org/elasticsearch/compute/data/MockBlockFactory.java Show resolved Hide resolved
x-pack/plugin/esql/compute/src/test/java/org/elasticsearch/compute/data/MockBlockFactory.java Outdated Show resolved Hide resolved
...k/plugin/esql/compute/src/test/java/org/elasticsearch/compute/operator/OperatorTestCase.java Outdated Show resolved Hide resolved
...k/plugin/esql/compute/src/test/java/org/elasticsearch/compute/operator/OperatorTestCase.java Outdated Show resolved Hide resolved
...k/plugin/esql/compute/src/test/java/org/elasticsearch/compute/operator/OperatorTestCase.java Outdated Show resolved Hide resolved
@ChrisHegarty ChrisHegarty requested a review from nik9000 October 3, 2023 11:52
@ChrisHegarty ChrisHegarty merged commit 29de48e into elastic:main Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nik9000 nik9000 nik9000 approved these changes

Assignees
No one assigned
Labels
:Analytics/ES|QL AKA ESQL >refactoring Team:QL (Deprecated) Meta label for query languages team v8.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChrisHegarty @elasticsearchmachine @nik9000