Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace 220_logs_default_pipeline.yml with java rest test (#99764) #100014

Merged
merged 2 commits into from
Oct 5, 2023

Conversation

gmarouli
Copy link
Contributor

The test fails because the logs template is not initialised in time for the test to retrieve it. To fix this we convert the yaml test to java rest test, this allows us to wait until the logs has been initialised before we continue with the test steps.

Fixes: #99764

@gmarouli gmarouli added >test Issues or PRs that are addressing/adding tests :Data Management/Indices APIs APIs to create and manage indices and templates labels Sep 28, 2023
@elasticsearchmachine elasticsearchmachine added v8.11.0 Team:Data Management Meta label for data/management team labels Sep 28, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

Copy link
Contributor

@andreidan andreidan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing this Mary

@mattc58 mattc58 added v8.12.0 and removed v8.11.0 labels Oct 4, 2023
@gmarouli
Copy link
Contributor Author

gmarouli commented Oct 5, 2023

@elasticmachine update branch

@gmarouli gmarouli added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Oct 5, 2023
@elasticsearchmachine elasticsearchmachine merged commit b0ee645 into elastic:main Oct 5, 2023
@gmarouli gmarouli deleted the fix-220-logs branch October 5, 2023 07:55
@gmarouli
Copy link
Contributor Author

gmarouli commented Oct 5, 2023

💚 All backports created successfully

Status Branch Result
8.11

Questions ?

Please refer to the Backport tool documentation

gmarouli added a commit to gmarouli/elasticsearch that referenced this pull request Oct 5, 2023
) (elastic#100014)

The test fails because the logs template is not initialised in time for
the test to retrieve it. To fix this we convert the yaml test to java
rest test, this allows us to wait until the logs has been initialised
before we continue with the test steps.

Fixes: elastic#99764
(cherry picked from commit b0ee645)
elasticsearchmachine pushed a commit that referenced this pull request Oct 5, 2023
…100014) (#100336)

The test fails because the logs template is not initialised in time for
the test to retrieve it. To fix this we convert the yaml test to java
rest test, this allows us to wait until the logs has been initialised
before we continue with the test steps.

Fixes: #99764
(cherry picked from commit b0ee645)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Data Management/Indices APIs APIs to create and manage indices and templates Team:Data Management Meta label for data/management team >test Issues or PRs that are addressing/adding tests v8.12.0
Projects
None yet
5 participants