-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace 220_logs_default_pipeline.yml with java rest test (#99764) #100014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmarouli
added
>test
Issues or PRs that are addressing/adding tests
:Data Management/Indices APIs
APIs to create and manage indices and templates
labels
Sep 28, 2023
elasticsearchmachine
added
v8.11.0
Team:Data Management
Meta label for data/management team
labels
Sep 28, 2023
Pinging @elastic/es-data-management (Team:Data Management) |
andreidan
approved these changes
Oct 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for fixing this Mary
@elasticmachine update branch |
gmarouli
added
the
auto-merge-without-approval
Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!)
label
Oct 5, 2023
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
gmarouli
added a commit
to gmarouli/elasticsearch
that referenced
this pull request
Oct 5, 2023
) (elastic#100014) The test fails because the logs template is not initialised in time for the test to retrieve it. To fix this we convert the yaml test to java rest test, this allows us to wait until the logs has been initialised before we continue with the test steps. Fixes: elastic#99764 (cherry picked from commit b0ee645)
elasticsearchmachine
pushed a commit
that referenced
this pull request
Oct 5, 2023
…100014) (#100336) The test fails because the logs template is not initialised in time for the test to retrieve it. To fix this we convert the yaml test to java rest test, this allows us to wait until the logs has been initialised before we continue with the test steps. Fixes: #99764 (cherry picked from commit b0ee645)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto-merge-without-approval
Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!)
:Data Management/Indices APIs
APIs to create and manage indices and templates
Team:Data Management
Meta label for data/management team
>test
Issues or PRs that are addressing/adding tests
v8.12.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test fails because the logs template is not initialised in time for the test to retrieve it. To fix this we convert the yaml test to java rest test, this allows us to wait until the logs has been initialised before we continue with the test steps.
Fixes: #99764