Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block and Vector creation can start to use a block factory that performs circuit breaking #99826

Closed
15 tasks done
Tracked by #99173
ChrisHegarty opened this issue Sep 22, 2023 · 5 comments
Closed
15 tasks done
Tracked by #99173
Labels
:Analytics/ES|QL AKA ESQL Team:QL (Deprecated) Meta label for query languages team v8.11.0

Comments

@ChrisHegarty
Copy link
Contributor

ChrisHegarty commented Sep 22, 2023

This meta issue lists a number of places in the ESQL runtime where Block and Vector creation can start to use a block factory that performs breaking/accountancy.

Working top-down there are cases where the implementation both creates and consumes blocks - do not escape the operator. In theory it should be more straightforward to start with - since their usage is localised.

relates #99173

@ChrisHegarty ChrisHegarty added Team:QL (Deprecated) Meta label for query languages team :Analytics/ES|QL AKA ESQL labels Sep 22, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-ql (Team:QL)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/elasticsearch-esql (:Query Languages/ES|QL)

@nik9000
Copy link
Member

nik9000 commented Sep 22, 2023

So I played a bit with things this afternoon. I believe step 0 is to get the EsqlQueryResponse and ExchangeResponse to properly close Blocks on the way out. this is a kind of hacky way to do that.

@nik9000
Copy link
Member

nik9000 commented Sep 24, 2023

on the way out. this is a kind of hacky way to do that.

And that doesn't quite work, because we let go of the pages before we actually render them. I'll bet there's a way around that. I wonder if we actually decRef after the render. That would work better.

@nik9000
Copy link
Member

nik9000 commented Oct 24, 2023

Looks like we're done here. There is more work to be done in 8.12 in #100528, but this is still work well done!

@nik9000 nik9000 closed this as completed Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/ES|QL AKA ESQL Team:QL (Deprecated) Meta label for query languages team v8.11.0
Projects
None yet
Development

No branches or pull requests

3 participants