-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Block and Vector creation can start to use a block factory that performs circuit breaking #99826
Comments
Pinging @elastic/es-ql (Team:QL) |
Pinging @elastic/elasticsearch-esql (:Query Languages/ES|QL) |
So I played a bit with things this afternoon. I believe step 0 is to get the |
And that doesn't quite work, because we let go of the pages before we actually render them. I'll bet there's a way around that. I wonder if we actually decRef after the render. That would work better. |
Add DriverContext and BlockFactory to GROK command to properly handle circuit breaking See #99826
Looks like we're done here. There is more work to be done in 8.12 in #100528, but this is still work well done! |
This meta issue lists a number of places in the ESQL runtime where Block and Vector creation can start to use a block factory that performs breaking/accountancy.
EsqlQueryResponse
and exchange sink ESQL: Close pages on response #99876BlockFactory
#100231ESQL: Tracker for tests impacted by the circuit breaker #100147Working top-down there are cases where the implementation both creates and consumes blocks - do not escape the operator. In theory it should be more straightforward to start with - since their usage is localised.
relates #99173
The text was updated successfully, but these errors were encountered: