-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TESTS] Make sure test end with ..Tests #9945
Comments
+1 I think we should rather take |
Or if a test class has '@test' then the class name must end with *Test |
@martijnvg I'm afraid we don't use the |
Yes, we take this approach we should also look for method names starting with |
This commit adds a simple testcase that ensures all our tests end with the right naming. Closes elastic#9945
This commit adds a simple testcase that ensures all our tests end with the right naming. Closes elastic#9945
thanks so much @brwe for finding this... |
We currently filter test classes by suffix
Test
orTests
(https://github.com/elasticsearch/elasticsearch/blob/master/pom.xml#L495), but there is no automation in place to guarantee that test classes actually end with this suffix. As a result, some tests did not run on CI without anyone noticing (see for example 600cb88). Would be great if we had some automation that checks that classes that derive from Test classes likeElasticsearchIntegrationTest
have the right suffix.The text was updated successfully, but these errors were encountered: