-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename ES templates and pipelines according to the naming conventions #98535
Comments
Pinging @elastic/es-data-management (Team:Data Management) |
The current plan is to rename only "stack" templates, meaning - such that are registered through Breaking this into implementation steps:
|
I would prefer that we not change the existing priority, and instead use a different priority for the new templates (250? 201? Either that or decrease the 'old' ones to 150 and use 200 for the new ones). The reason is that we document the existing priority (200) on the index template page — https://www.elastic.co/guide/en/elasticsearch/reference/8.9/index-templates.html under the "Avoid index pattern collisions" section. I think changing the priority verges on the line of a breaking change. We'll need to update this documentation as well, as part of this work. |
@dakrone the scope of this issue covers only index templates that are installed by
This is the reason not to keep current index templates with same priority and install the new ones with a different (higher) priority. |
@eyalkoren yep you're right, I misread. Thanks for the correction! In that case it sounds like the docs wouldn't need to change, sorry about my mistake! |
@andreidan in the context of this issue, we'd want to rename some stack component templates. How can we go about this since some of these are shadowed for serverless? Would we need to merge the changes at the same time in the serverless repo? |
We can't rename component templates as the current names may be used in user's index templates. So storing component templates both under the old and the new name makes sense. However, I think we can just rename index templates instead of storing them under the old name with a lower precedence and under the new name with the current precedence. That's because there's no other entity that would reference an index template with its name. Let me know if I'm missing something but I think we can just move them out of the |
@felixbarny The serverless override is done at the physical json file level based on path, which sounds like won't change according to > "They will use the same template file resources" ? If the template resource files remain named the same there's nothing to do as the serverless overrides exist already. If the actual files get renamed, or new files get added, serverless be updated such that overrides with the new names exist. |
The file name will change. I suppose we'll need to merge the serverless PR that renames accordingly at the same time as the PR in the main Elasticsearch repo. |
## Summary Fixes #163141 Fixes #160288 Blocked by: - elastic/elasticsearch#98535 This switches where integrations installed by EPM get their default index settings from to use the [source-of-truth component templates supplied by Elasticsearch](https://github.com/elastic/elasticsearch/tree/main/x-pack/plugin/core/template-resources/src/main/resources). This will help ensure that data streams configured by EPM always get the same defaults as data streams the user creates using the default `logs-*-*` and `metrics-*-*` templates. For now, no default mappings are sourced from Elasticsearch. As part of this change the template format version was incremented to force EPM to reinstall all templates and rollover data streams on the Stack upgrade to the version including this change. ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: kibanamachine <[email protected]>
…63731) ## Summary Fixes elastic#163141 Fixes elastic#160288 Blocked by: - elastic/elasticsearch#98535 This switches where integrations installed by EPM get their default index settings from to use the [source-of-truth component templates supplied by Elasticsearch](https://github.com/elastic/elasticsearch/tree/main/x-pack/plugin/core/template-resources/src/main/resources). This will help ensure that data streams configured by EPM always get the same defaults as data streams the user creates using the default `logs-*-*` and `metrics-*-*` templates. For now, no default mappings are sourced from Elasticsearch. As part of this change the template format version was incremented to force EPM to reinstall all templates and rollover data streams on the Stack upgrade to the version including this change. ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: kibanamachine <[email protected]>
See #96267
Also add docs for the new naming convention.
The text was updated successfully, but these errors were encountered: