Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable all aggregations on counter fields #97882

Closed
salvatore-campagna opened this issue Jul 24, 2023 · 1 comment · Fixed by #97974
Closed

Enable all aggregations on counter fields #97882

salvatore-campagna opened this issue Jul 24, 2023 · 1 comment · Fixed by #97974
Labels
:Analytics/Aggregations Aggregations >enhancement Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v8.10.0

Comments

@salvatore-campagna
Copy link
Contributor

Description

Failing aggregations as unsupported on counter fields is blocking TSDB adoption. Aggregations like sum over a counter field fail and this causes issues in existing (especially custom) dashboards. TO ease transition to TSDB and favour its adoption we decided to enable all aggregations on counter fields even if they don't make sense.

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo (Team:Analytics)

@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Jul 24, 2023
salvatore-campagna added a commit that referenced this issue Aug 8, 2023
Here we enable aggregations previously not allowed on fields of type counter.
The decision of enabling such aggregations even if the result is "meaningless"
for counters has been taken to favour TSDB adoption.

Aggregations now allowed, other than the existing ones, include:
* avg
* box plot
* cardinality
* extended stats
* median absolute deviation
* percentile ranks
* percentiles
* stats
* sum
* value count

I included tests for the weighted average and matrix stats aggregations too.

Resolves #97882
salvatore-campagna added a commit to salvatore-campagna/elasticsearch that referenced this issue Aug 8, 2023
Here we enable aggregations previously not allowed on fields of type counter.
The decision of enabling such aggregations even if the result is "meaningless"
for counters has been taken to favour TSDB adoption.

Aggregations now allowed, other than the existing ones, include:
* avg
* box plot
* cardinality
* extended stats
* median absolute deviation
* percentile ranks
* percentiles
* stats
* sum
* value count

I included tests for the weighted average and matrix stats aggregations too.

Resolves elastic#97882

(cherry picked from commit d0b2f65)

# Conflicts:
#	rest-api-spec/src/yamlRestTest/resources/rest-api-spec/test/tsdb/120_counter_fields.yml
salvatore-campagna added a commit that referenced this issue Aug 8, 2023
…98294)

* Enable all remaining metric aggregations on counters (#97974)

Here we enable aggregations previously not allowed on fields of type counter.
The decision of enabling such aggregations even if the result is "meaningless"
for counters has been taken to favour TSDB adoption.

Aggregations now allowed, other than the existing ones, include:
* avg
* box plot
* cardinality
* extended stats
* median absolute deviation
* percentile ranks
* percentiles
* stats
* sum
* value count

I included tests for the weighted average and matrix stats aggregations too.

Resolves #97882

(cherry picked from commit d0b2f65)

# Conflicts:
#	rest-api-spec/src/yamlRestTest/resources/rest-api-spec/test/tsdb/120_counter_fields.yml

* fix: skip versions up to and including 8.9.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/Aggregations Aggregations >enhancement Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v8.10.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants