Format checking in InternalComposite should be done earlier #94760
Labels
:Analytics/Aggregations
Aggregations
>bug
Team:Analytics
Meta label for analytical engine team (ESQL/Aggs/Geo)
Comments
|
Pinging @elastic/es-analytics-geo (Team:Analytics) |
elasticsearchmachine
added
the
Team:Analytics
romseygeek
added a commit
that referenced
this issue
Apr 3, 2023
Composite after_keys are currently only formatted when they are serialized to xcontent, meaning that a key that cannot be formatted will not be caught until after all the results from an aggregation have been reduced. This wastes CPU time, and also blocks any move to chunked xcontent handling in search responses. This commit moves formatting of an after_key into InternalComposite's constructor, catching these errors earlier. Resolves #94760
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
InternalComposite.formatObject() can throw an IllegalArgumentException if the format to be applied to a composite key leads to a loss of information (eg, a date histogram with a width of one day is then given a date format of 'YYYY-mm', meaning that multiple buckets from the same month would produce the same key). This is currently only checked during serialization, meaning that we can do a great deal of work building aggregations only to then throw the result away at the end. This also causes a problem for converting the
_searchendpoint to using chunked xcontent serialization, as the HTTP response code is the first thing sent back, and so errors that occur during later serialization don't get handled correctly.The text was updated successfully, but these errors were encountered: