Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Example plugin test compile error #88985

Closed
hendrikmuhs opened this issue Aug 1, 2022 · 2 comments · Fixed by #89004
Closed

Example plugin test compile error #88985

hendrikmuhs opened this issue Aug 1, 2022 · 2 comments · Fixed by #89004
Labels
:Search Foundations/Mapping Index mappings, including merging and defining field types Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch >test-failure Triaged test failures from CI

Comments

@hendrikmuhs
Copy link

CI Link

https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+main+periodic+example-plugins/268/console

Repro line

gradlew :rescore:compileJava

Does it reproduce?

Yes

Applicable branches

main

Failure history

No response

Failure excerpt

Looks like a regression caused by #88735

/CC @jdconrad
@hendrikmuhs hendrikmuhs added :Search Foundations/Mapping Index mappings, including merging and defining field types needs:triage Requires assignment of a team area label labels Aug 1, 2022
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search (Team:Search)

@elasticsearchmachine elasticsearchmachine added Team:Search Meta label for search team and removed needs:triage Requires assignment of a team area label labels Aug 1, 2022
@hendrikmuhs hendrikmuhs added >test-failure Triaged test failures from CI and removed Team:Search Meta label for search team labels Aug 1, 2022
@elasticsearchmachine elasticsearchmachine added the Team:Search Meta label for search team label Aug 1, 2022
arteam added a commit to arteam/elasticsearch that referenced this issue Aug 1, 2022
@arteam
Fix compilation in the rescore plugin
d3ed689 
Add source fallback operation when looking up a the factor field added in elastic#88735

Resolves elastic#88985
@arteam arteam mentioned this issue Aug 1, 2022
Merged
@jtibshirani
Copy link
Contributor

I wonder if we should make sure example compile errors fail PR builds. I'm not sure why this compile task didn't run as part of the main build. CC @elastic/es-delivery

arteam added a commit that referenced this issue Aug 1, 2022
@arteam
Fix compilation in the rescore plugin (#89004)
2a03ac3 
Add source fallback operation when looking up a the factor field added in #88735

Resolves #88985
@javanna javanna added Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch and removed Team:Search Meta label for search team labels Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
:Search Foundations/Mapping Index mappings, including merging and defining field types Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch >test-failure Triaged test failures from CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix compilation in the rescore example plugin arteam/elasticsearch
4 participants
@javanna @hendrikmuhs @jtibshirani @elasticsearchmachine