Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] BuildTests testSerialization failing #85800

Closed
tvernum opened this issue Apr 12, 2022 · 3 comments · Fixed by #85827
Closed

[CI] BuildTests testSerialization failing #85800

tvernum opened this issue Apr 12, 2022 · 3 comments · Fixed by #85827
Assignees
@rjernst
Labels
:Core/Infra/Core Core issues without another label :Delivery/Packaging RPM and deb packaging, tar and zip archives, shell and batch scripts Team:Core/Infra Meta label for core/infra team Team:Delivery Meta label for Delivery team >test-failure Triaged test failures from CI

Comments

@tvernum
Copy link
Contributor

tvernum commented Apr 12, 2022

The FIPS bit isn't relevant.
The same seed value will reproduce on a non-FIPS build.

Relates: #85796

Build scan:
https://gradle-enterprise.elastic.co/s/fpe7bebkpagbw/tests/:server:test/org.elasticsearch.BuildTests/testSerialization

Reproduction line:
./gradlew ':server:test' --tests "org.elasticsearch.BuildTests.testSerialization" -Dtests.seed=3687CD616C610092 -Dtests.locale=fr-CH -Dtests.timezone=America/Whitehorse -Druntime.java=17 -Dtests.fips.enabled=true

Applicable branches:
master

Reproduces locally?:
Yes

Failure history:
https://gradle-enterprise.elastic.co/scans/tests?tests.container=org.elasticsearch.BuildTests&tests.test=testSerialization

Failure excerpt:

java.lang.AssertionError: WriteableBuild mutation should not be equal to original
Expected: not <org.elasticsearch.BuildTests$WriteableBuild@dd8f0d29>
     but: was <org.elasticsearch.BuildTests$WriteableBuild@dd8f0d29>

  at __randomizedtesting.SeedInfo.seed([3687CD616C610092:625FAC294B333D0E]:0)
  at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:18)
  at org.junit.Assert.assertThat(Assert.java:956)
  at org.elasticsearch.test.EqualsHashCodeTestUtils.checkEqualsAndHashCode(EqualsHashCodeTestUtils.java:73)
  at org.elasticsearch.BuildTests.testSerialization(BuildTests.java:138)
  at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(NativeMethodAccessorImpl.java:-2)
  at jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
  at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
  at java.lang.reflect.Method.invoke(Method.java:568)
  at com.carrotsearch.randomizedtesting.RandomizedRunner.invoke(RandomizedRunner.java:1758)
  at com.carrotsearch.randomizedtesting.RandomizedRunner$8.evaluate(RandomizedRunner.java:946)
  at com.carrotsearch.randomizedtesting.RandomizedRunner$9.evaluate(RandomizedRunner.java:982)
  at com.carrotsearch.randomizedtesting.RandomizedRunner$10.evaluate(RandomizedRunner.java:996)
  at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
  at org.apache.lucene.tests.util.TestRuleSetupTeardownChained$1.evaluate(TestRuleSetupTeardownChained.java:44)
  at org.apache.lucene.tests.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43)
  at org.apache.lucene.tests.util.TestRuleThreadAndTestName$1.evaluate(TestRuleThreadAndTestName.java:45)
  at org.apache.lucene.tests.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgnoreAfterMaxFailures.java:60)
  at org.apache.lucene.tests.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:44)
  at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
  at com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:375)
  at com.carrotsearch.randomizedtesting.ThreadLeakControl.forkTimeoutingTask(ThreadLeakControl.java:824)
  at com.carrotsearch.randomizedtesting.ThreadLeakControl$3.evaluate(ThreadLeakControl.java:475)
  at com.carrotsearch.randomizedtesting.RandomizedRunner.runSingleTest(RandomizedRunner.java:955)
  at com.carrotsearch.randomizedtesting.RandomizedRunner$5.evaluate(RandomizedRunner.java:840)
  at com.carrotsearch.randomizedtesting.RandomizedRunner$6.evaluate(RandomizedRunner.java:891)
  at com.carrotsearch.randomizedtesting.RandomizedRunner$7.evaluate(RandomizedRunner.java:902)
  at org.apache.lucene.tests.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43)
  at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
  at org.apache.lucene.tests.util.TestRuleStoreClassName$1.evaluate(TestRuleStoreClassName.java:38)
  at com.carrotsearch.randomizedtesting.rules.NoShadowingOrOverridesOnMethodsRule$1.evaluate(NoShadowingOrOverridesOnMethodsRule.java:40)
  at com.carrotsearch.randomizedtesting.rules.NoShadowingOrOverridesOnMethodsRule$1.evaluate(NoShadowingOrOverridesOnMethodsRule.java:40)
  at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
  at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
  at org.apache.lucene.tests.util.TestRuleAssertionsRequired$1.evaluate(TestRuleAssertionsRequired.java:53)
  at org.apache.lucene.tests.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43)
  at org.apache.lucene.tests.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:44)
  at org.apache.lucene.tests.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgnoreAfterMaxFailures.java:60)
  at org.apache.lucene.tests.util.TestRuleIgnoreTestSuites$1.evaluate(TestRuleIgnoreTestSuites.java:47)
  at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
  at com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:375)
  at com.carrotsearch.randomizedtesting.ThreadLeakControl.lambda$forkTimeoutingTask$0(ThreadLeakControl.java:831)
  at java.lang.Thread.run(Thread.java:833)
@tvernum tvernum added :Delivery/Packaging RPM and deb packaging, tar and zip archives, shell and batch scripts :Core/Infra/Core Core issues without another label >test-failure Triaged test failures from CI labels Apr 12, 2022
@elasticmachine elasticmachine added Team:Core/Infra Meta label for core/infra team Team:Delivery Meta label for Delivery team labels Apr 12, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-delivery (Team:Delivery)

@tvernum
Copy link
Contributor Author

tvernum commented Apr 12, 2022

In #85796 the random case 1 now returns a cloned object, not a modified object.
https://github.com/elastic/elasticsearch/pull/85796/files#diff-23177b81dba8db17d82fbe4bdd0369b79035fbd34469c708226837a83f275b32L198-R154

tvernum added a commit to tvernum/elasticsearch that referenced this issue Apr 12, 2022
@tvernum
[TEST] Mute BuildTests.testSerialization
7aa50f3 
Relates: elastic#85800
@tvernum tvernum mentioned this issue Apr 12, 2022
Merged
elasticsearchmachine pushed a commit that referenced this issue Apr 12, 2022
@tvernum
[TEST] Mute BuildTests.testSerialization (#85801)
54fe403 
Relates: #85800
rjernst added a commit to rjernst/elasticsearch that referenced this issue Apr 12, 2022
@rjernst
Fix BuildTests serialization
baca7db 
This commit fixes a randomization bug in the tests for Build
serialization, which could generate the same object when it should
mutate.

closes elastic#85800
@rjernst rjernst mentioned this issue Apr 12, 2022
Merged
rjernst added a commit that referenced this issue Apr 12, 2022
@rjernst
Fix BuildTests serialization (#85827)
077a2de 
This commit fixes a randomization bug in the tests for Build
serialization, which could generate the same object when it should
mutate.

closes #85800
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rjernst rjernst

Labels
:Core/Infra/Core Core issues without another label :Delivery/Packaging RPM and deb packaging, tar and zip archives, shell and batch scripts Team:Core/Infra Meta label for core/infra team Team:Delivery Meta label for Delivery team >test-failure Triaged test failures from CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix BuildTests serialization rjernst/elasticsearch
3 participants
@rjernst @tvernum @elasticmachine