Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Installation class for Packaging Tests with multiple nodes #79688

Open
jkakavas opened this issue Oct 24, 2021 · 1 comment
Open

Enhance Installation class for Packaging Tests with multiple nodes #79688

jkakavas opened this issue Oct 24, 2021 · 1 comment
Labels
:Delivery/Build Build or test infrastructure Team:Delivery Meta label for Delivery team >test Issues or PRs that are addressing/adding tests

Comments

@jkakavas
Copy link
Member

Now that we have packaging tests that start multiple nodes ( EnrollmentProcessTests ) some of the assumptions that we are making throughout the packaging test code base are no longer valid.

For instance, the http/transport ports that the installation are bound to is not necessarily 9200/9300, but could be 9201/9301 etc depending on how many nodes we start. What's more, the assumption that we have a single installation in the entire PackagingTestCase class is not strictly valid any more.

I added an ugly hack for this in #77718 so I'm opening this issue here to discuss about more robust and maintainable solutions

@jkakavas jkakavas added >test Issues or PRs that are addressing/adding tests :Delivery/Build Build or test infrastructure labels Oct 24, 2021
@elasticmachine elasticmachine added the Team:Delivery Meta label for Delivery team label Oct 24, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-delivery (Team:Delivery)

pugnascotia added a commit that referenced this issue Jan 13, 2022
Fixes #81999.

Change `EnrollmentProcessTests` and the testing infrastructure so
that `ServerUtils` can send requests to the correct local port.
This is also a step towards addressing #79688.

Also change the Iron Bank build to that it works on aarch64. This
isn't currently a supported configuration, but it's useful for
testing.
pugnascotia added a commit that referenced this issue Jan 13, 2022
Fixes #81999.

Change `EnrollmentProcessTests` and the testing infrastructure so
that `ServerUtils` can send requests to the correct local port.
This is also a step towards addressing #79688.

Also change the Iron Bank build to that it works on aarch64. This
isn't currently a supported configuration, but it's useful for
testing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Delivery/Build Build or test infrastructure Team:Delivery Meta label for Delivery team >test Issues or PRs that are addressing/adding tests
Projects
None yet
Development

No branches or pull requests

2 participants