Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exception message due to missing blob in Azure repository omits path #75916

Closed
DaveCTurner opened this issue Aug 2, 2021 · 1 comment · Fixed by #75920
Closed

Exception message due to missing blob in Azure repository omits path #75916

DaveCTurner opened this issue Aug 2, 2021 · 1 comment · Fixed by #75920
Assignees
@fcofdez
Labels
>bug :Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination.

Comments

@DaveCTurner
Copy link
Contributor

Today if a blob is removed from an Azure repo we log something like this:

SnapshotMissingException[[REPO:SNAPSHOT/UUID] is missing]; nested: NoSuchFileException[Blob [snap-UUID.dat] not found]

There are many files in the repo called snap-UUID.dat in various places, and this message doesn't tell us which one is missing since it only includes the leaf blob name and not its full path. We should include the path in messages like this.
@DaveCTurner DaveCTurner added >bug :Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs labels Aug 2, 2021
@elasticmachine elasticmachine added the Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. label Aug 2, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

@fcofdez fcofdez self-assigned this Aug 2, 2021
fcofdez added a commit to fcofdez/elasticsearch that referenced this issue Aug 2, 2021
@fcofdez
Include full key in Azure read operations exceptions
92dadae 
Closes elastic#75916
@fcofdez fcofdez mentioned this issue Aug 2, 2021
Merged
fcofdez added a commit that referenced this issue Aug 2, 2021
@fcofdez
Include full key in Azure read operations exceptions (#75920)
09a5db3 
Closes #75916
elasticsearchmachine pushed a commit to elasticsearchmachine/elasticsearch that referenced this issue Aug 2, 2021
@fcofdez
Include full key in Azure read operations exceptions (elastic#75920)
29e8f32 
Closes elastic#75916
fcofdez added a commit that referenced this issue Aug 2, 2021
@elasticsearchmachine @fcofdez
Include full key in Azure read operations exceptions (#75925)
a4c1f73 
Closes #75916
Backport of #75920

Co-authored-by: Francisco Fernández Castaño <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fcofdez fcofdez

Labels
>bug :Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Include full blob key in Azure read operations exceptions fcofdez/elasticsearch
3 participants
@fcofdez @DaveCTurner @elasticmachine