Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] CollapsingTopDocsCollectorSearchAfterTests testCollapseFloat failing #75736

Closed
pugnascotia opened this issue Jul 27, 2021 · 2 comments
Closed

[CI] CollapsingTopDocsCollectorSearchAfterTests testCollapseFloat failing #75736

pugnascotia opened this issue Jul 27, 2021 · 2 comments
Assignees
@jtibshirani
Labels
:Search Relevance/Ranking Scoring, rescoring, rank evaluation. Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch >test-failure Triaged test failures from CI

Comments

@pugnascotia
Copy link
Contributor

Build scan:
https://gradle-enterprise.elastic.co/s/weozxelifwxzs/tests/:server:test/org.apache.lucene.grouping.CollapsingTopDocsCollectorSearchAfterTests/testCollapseFloat

Reproduction line:
./gradlew ':server:test' --tests "org.apache.lucene.grouping.CollapsingTopDocsCollectorSearchAfterTests.testCollapseFloat" -Dtests.seed=BA4F7435087D3D78 -Dtests.locale=es-SV -Dtests.timezone=Brazil/West -Druntime.java=8

Applicable branches:
7.x

Reproduces locally?:
Yes

Failure history:
https://gradle-enterprise.elastic.co/scans/tests?tests.container=org.apache.lucene.grouping.CollapsingTopDocsCollectorSearchAfterTests&tests.test=testCollapseFloat

Failure excerpt:

java.lang.AssertionError: expected:<17> but was:<16>

  at __randomizedtesting.SeedInfo.seed([BA4F7435087D3D78:46912F8A07248869]:0)
  at org.junit.Assert.fail(Assert.java:88)
  at org.junit.Assert.failNotEquals(Assert.java:834)
  at org.junit.Assert.assertEquals(Assert.java:645)
  at org.junit.Assert.assertEquals(Assert.java:631)
  at org.apache.lucene.grouping.CollapsingTopDocsCollectorSearchAfterTests.assertSearchCollapse(CollapsingTopDocsCollectorSearchAfterTests.java:137)
  at org.apache.lucene.grouping.CollapsingTopDocsCollectorSearchAfterTests.assertSearchCollapse(CollapsingTopDocsCollectorSearchAfterTests.java:56)
  at org.apache.lucene.grouping.CollapsingTopDocsCollectorSearchAfterTests.testCollapseFloat(CollapsingTopDocsCollectorSearchAfterTests.java:208)
  at sun.reflect.NativeMethodAccessorImpl.invoke0(NativeMethodAccessorImpl.java:-2)
  at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
  at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
  at java.lang.reflect.Method.invoke(Method.java:498)
  at com.carrotsearch.randomizedtesting.RandomizedRunner.invoke(RandomizedRunner.java:1750)
  at com.carrotsearch.randomizedtesting.RandomizedRunner$8.evaluate(RandomizedRunner.java:938)
  at com.carrotsearch.randomizedtesting.RandomizedRunner$9.evaluate(RandomizedRunner.java:974)
  at com.carrotsearch.randomizedtesting.RandomizedRunner$10.evaluate(RandomizedRunner.java:988)
  at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
  at org.apache.lucene.util.TestRuleSetupTeardownChained$1.evaluate(TestRuleSetupTeardownChained.java:49)
  at org.apache.lucene.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:45)
  at org.apache.lucene.util.TestRuleThreadAndTestName$1.evaluate(TestRuleThreadAndTestName.java:48)
  at org.apache.lucene.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgnoreAfterMaxFailures.java:64)
  at org.apache.lucene.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:47)
  at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
  at com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:368)
  at com.carrotsearch.randomizedtesting.ThreadLeakControl.forkTimeoutingTask(ThreadLeakControl.java:817)
  at com.carrotsearch.randomizedtesting.ThreadLeakControl$3.evaluate(ThreadLeakControl.java:468)
  at com.carrotsearch.randomizedtesting.RandomizedRunner.runSingleTest(RandomizedRunner.java:947)
  at com.carrotsearch.randomizedtesting.RandomizedRunner$5.evaluate(RandomizedRunner.java:832)
  at com.carrotsearch.randomizedtesting.RandomizedRunner$6.evaluate(RandomizedRunner.java:883)
  at com.carrotsearch.randomizedtesting.RandomizedRunner$7.evaluate(RandomizedRunner.java:894)
  at org.apache.lucene.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:45)
  at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
  at org.apache.lucene.util.TestRuleStoreClassName$1.evaluate(TestRuleStoreClassName.java:41)
  at com.carrotsearch.randomizedtesting.rules.NoShadowingOrOverridesOnMethodsRule$1.evaluate(NoShadowingOrOverridesOnMethodsRule.java:40)
  at com.carrotsearch.randomizedtesting.rules.NoShadowingOrOverridesOnMethodsRule$1.evaluate(NoShadowingOrOverridesOnMethodsRule.java:40)
  at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
  at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
  at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
  at org.apache.lucene.util.TestRuleAssertionsRequired$1.evaluate(TestRuleAssertionsRequired.java:53)
  at org.apache.lucene.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:47)
  at org.apache.lucene.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgnoreAfterMaxFailures.java:64)
  at org.apache.lucene.util.TestRuleIgnoreTestSuites$1.evaluate(TestRuleIgnoreTestSuites.java:54)
  at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
  at com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:368)
  at java.lang.Thread.run(Thread.java:748)
@pugnascotia pugnascotia added :Search Relevance/Ranking Scoring, rescoring, rank evaluation. >test-failure Triaged test failures from CI labels Jul 27, 2021
@elasticmachine elasticmachine added the Team:Search Meta label for search team label Jul 27, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (Team:Search)

@jtibshirani jtibshirani self-assigned this Jul 27, 2021
jtibshirani added a commit that referenced this issue Jul 28, 2021
@jtibshirani
Fix incorrect assertions in CollapsingTopDocsCollectorSearchAfterTests
e637a64 
These assertions were simply wrong, but took time to catch as they were very
rarely triggered.

Fixes #75736.
jtibshirani added a commit that referenced this issue Jul 28, 2021
@jtibshirani
Fix incorrect assertions in CollapsingTopDocsCollectorSearchAfterTests
02c9e2a 
These assertions were simply wrong, but took time to catch as they were very
rarely triggered.

Fixes #75736.
@jtibshirani
Copy link
Contributor

The assertion that tripped was actually just wrong! I pushed a test fix:

ywangd pushed a commit to ywangd/elasticsearch that referenced this issue Jul 30, 2021
@jtibshirani @ywangd
Remove incorrect assertion in CollapsingTopDocsCollectorSearchAfterTests
f082ebc 
This assertion was simply wrong, but took time to catch as it was very rarely
triggered. The test already checks the correct assertion at an earlier time.

Fixes elastic#75736.
@javanna javanna added Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch and removed Team:Search Meta label for search team labels Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jtibshirani jtibshirani

Labels
:Search Relevance/Ranking Scoring, rescoring, rank evaluation. Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch >test-failure Triaged test failures from CI
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@javanna @jtibshirani @pugnascotia @elasticmachine