Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reproducible Failure in org.elasticsearch.search.aggregations.bucket.TermsDocCountErrorIT.testIncrementalReduction #75667

Closed
original-brownbear opened this issue Jul 25, 2021 · 1 comment · Fixed by #76391
Closed

Reproducible Failure in org.elasticsearch.search.aggregations.bucket.TermsDocCountErrorIT.testIncrementalReduction #75667

original-brownbear opened this issue Jul 25, 2021 · 1 comment · Fixed by #76391
Assignees
@imotov
Labels
:Analytics/Aggregations Aggregations Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test-failure Triaged test failures from CI

Comments

@original-brownbear
Copy link
Member

With current master:

./gradlew ':server:internalClusterTest' --tests "org.elasticsearch.search.aggregations.bucket.TermsDocCountErrorIT.testIncrementalReduction" -Dtests.seed=370A19D46176CFA7 -Dtests.locale=zh-SG -Dtests.timezone=Atlantic/Madeira -Druntime.java=16

fails 100% of the time with

  2> REPRODUCE WITH: ./gradlew ':server:internalClusterTest' --tests "org.elasticsearch.search.aggregations.bucket.TermsDocCountErrorIT.testIncrementalReduction" -Dtests.seed=370A19D46176CFA7 -Dtests.locale=zh-SG -Dtests.timezone=Atlantic/Madeira -Druntime.java=16
  2> java.lang.AssertionError: 
    Expected: <0L>
         but: was <1L>
        at __randomizedtesting.SeedInfo.seed([370A19D46176CFA7:1A95D442705B6E10]:0)
        at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:18)
        at org.junit.Assert.assertThat(Assert.java:956)
        at org.junit.Assert.assertThat(Assert.java:923)
        at org.elasticsearch.search.aggregations.bucket.TermsDocCountErrorIT.testIncrementalReduction(TermsDocCountErrorIT.java:1048)

for me. Also fails for a bunch of other seeds as well.
@original-brownbear original-brownbear added :Analytics/Aggregations Aggregations >test-failure Triaged test failures from CI labels Jul 25, 2021
@elasticmachine elasticmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Jul 25, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo (Team:Analytics)

original-brownbear added a commit to original-brownbear/elasticsearch that referenced this issue Jul 25, 2021
@original-brownbear
Mute org.elasticsearch.search.aggregations.bucket.TermsDocCountErrorI…
f75ad77 
…T.testIncrementalReduction

Relates elastic#75667
@original-brownbear original-brownbear mentioned this issue Jul 25, 2021
Merged
original-brownbear added a commit that referenced this issue Jul 25, 2021
@original-brownbear
Mute org.elasticsearch.search.aggregations.bucket.TermsDocCountErrorI…
1098737 
…T.testIncrementalReduction (#75668)

Relates #75667
@gwbrown gwbrown mentioned this issue Jul 26, 2021
Merged
@imotov imotov self-assigned this Jul 26, 2021
ywangd pushed a commit to ywangd/elasticsearch that referenced this issue Jul 30, 2021
@original-brownbear @ywangd
Mute org.elasticsearch.search.aggregations.bucket.TermsDocCountErrorI…
82c0a51 
…T.testIncrementalReduction (elastic#75668)

Relates elastic#75667
imotov added a commit to imotov/elasticsearch that referenced this issue Aug 11, 2021
@imotov
Fix docCountError calculation for multiple reduces
9443de3 
Fix docCountError calculation in case of multiple reduces. It fixes 2 mistakes
in elastic#43874. The first error was introduced in the original PR, where unknown doc
count errors were initialized equal to 0, the second was introduced during in
order to fix the first one by ignoring these 0s, which essentially disabled the
original fix.

Fixes elastic#75667
@imotov imotov mentioned this issue Aug 11, 2021
Merged
imotov added a commit that referenced this issue Aug 12, 2021
@imotov
Fix docCountError calculation for multiple reduces (#76391)
e350211 
Fix docCountError calculation in case of multiple reduces. It fixes 2 mistakes
in #43874. The first error was introduced in the original PR, where unknown doc
count errors were initialized equal to 0, the second was introduced during in
order to fix the first one by ignoring these 0s, which essentially disabled the
original fix.

Fixes #75667
imotov added a commit to imotov/elasticsearch that referenced this issue Aug 12, 2021
@imotov
Fix docCountError calculation for multiple reduces (elastic#76391)
5db7196 
Fix docCountError calculation in case of multiple reduces. It fixes 2 mistakes
in elastic#43874. The first error was introduced in the original PR, where unknown doc
count errors were initialized equal to 0, the second was introduced during in
order to fix the first one by ignoring these 0s, which essentially disabled the
original fix.

Fixes elastic#75667
@imotov imotov mentioned this issue Aug 12, 2021
Merged
imotov added a commit that referenced this issue Aug 16, 2021
@imotov @Hohol
[7.x] Fix wrong error upper bound when performing incremental reducti…
d13ec5e 
…ons (#43874) (#76475)

When performing incremental reductions, 0 value of docCountError may mean that
the error was not previously calculated, or that the error was indeed previously
calculated and its value was 0. We end up rejecting true values set to 0 this
way. This may lead to wrong upper bound of error in result. To fix it, this PR
makes docCountError nullable. null values mean that error was not calculated
yet.

Fixes #40005, #75667

Co-authored-by: Nikita Glashenko <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@imotov imotov

Labels
:Analytics/Aggregations Aggregations Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test-failure Triaged test failures from CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix docCountError calculation for multiple reduces imotov/elasticsearch
3 participants
@imotov @original-brownbear @elasticmachine