Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keyword fields above ignore_above to the _ignored field #74228

Closed
cbuescher opened this issue Jun 17, 2021 · 1 comment · Fixed by #74418
Closed

Add keyword fields above ignore_above to the _ignored field #74228

cbuescher opened this issue Jun 17, 2021 · 1 comment · Fixed by #74418
Assignees
Labels
>enhancement :Search/Search Search-related issues that do not fall into other categories Team:Search Meta label for search team v7.14.0 v8.0.0-alpha1

Comments

@cbuescher
Copy link
Member

cbuescher commented Jun 17, 2021

Currently the _ignore field indexes and stores the names of every field in a document that has been ignored
because it was malformed and ignore_malformed was turned on. The goal is to give the user a means to identify documents
where values have been dropped and warn that these values are not searchable or aggregatable, althought they might be
present in the "_source".
Since the ignore_above option for keyword fields serves a somewhat similar purpose (drop values if they exceed a certain length, mostly as a safeguard for the system), we should also add these fields to the "_ignored" field.

Relates to #74121

@cbuescher cbuescher added >enhancement :Search/Search Search-related issues that do not fall into other categories labels Jun 17, 2021
@elasticmachine elasticmachine added the Team:Search Meta label for search team label Jun 17, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (Team:Search)

@cbuescher cbuescher self-assigned this Jun 22, 2021
cbuescher pushed a commit to cbuescher/elasticsearch that referenced this issue Jun 22, 2021
Currently the `_ignore` field indexes and stores the names of every field in a document that has been ignored
because eg. it was malformed. The `ignore_above` option for keyword-type fields
serves a somewhat similar purpose, so this change add logix that  adds these
fields to the "_ignored" field as well for `keyword`, `wildcard` and
`icu_collation_keyword` fields.

Closes elastic#74228
cbuescher pushed a commit that referenced this issue Jun 22, 2021
Currently the `_ignore` field indexes and stores the names of every field in a document that has been ignored
because eg. it was malformed. The `ignore_above` option for keyword-type fields
serves a somewhat similar purpose, so this change add logix that  adds these
fields to the "_ignored" field as well for `keyword`, `wildcard` and
`icu_collation_keyword` fields.

Closes #74228
cbuescher pushed a commit to cbuescher/elasticsearch that referenced this issue Jun 22, 2021
Currently the `_ignore` field indexes and stores the names of every field in a document that has been ignored
because eg. it was malformed. The `ignore_above` option for keyword-type fields
serves a somewhat similar purpose, so this change add logix that  adds these
fields to the "_ignored" field as well for `keyword`, `wildcard` and
`icu_collation_keyword` fields.

Closes elastic#74228
cbuescher pushed a commit that referenced this issue Jun 23, 2021
Currently the `_ignore` field indexes and stores the names of every field in a document that has been ignored
because eg. it was malformed. The `ignore_above` option for keyword-type fields
serves a somewhat similar purpose, so this change add logix that  adds these
fields to the "_ignored" field as well for `keyword`, `wildcard` and
`icu_collation_keyword` fields.

Closes #74228
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>enhancement :Search/Search Search-related issues that do not fall into other categories Team:Search Meta label for search team v7.14.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants