[CI] GeoIpCliTests classMethod failing on Windows #71145
Assignees
Labels
:Data Management/Ingest Node
Execution or management of Ingest Pipelines including GeoIP
Team:Data Management
Meta label for data/management team
>test-failure
Triaged test failures from CI
Comments
mark-vieira
added
:Data Management/Ingest Node
elasticmachine
added
the
Team:Data Management
|
Pinging @elastic/es-core-features (Team:Core/Features) |
|
@probakowski do you mind taking a look since you added this test today? FYI, I've muted this on |
|
Thanks @mark-vieira, I'll take a look |
|
Muted this in |
probakowski
added a commit
that referenced
this issue
Apr 1, 2021
Instead of creating directories manually under temp dir we should simply use createTempDir() twice. This should make Windows be able to delete directories correctly. This PR also removes unused method. Fixes #71145
probakowski
added a commit
to probakowski/elasticsearch
that referenced
this issue
Apr 1, 2021
Instead of creating directories manually under temp dir we should simply use createTempDir() twice. This should make Windows be able to delete directories correctly. This PR also removes unused method. Fixes elastic#71145
probakowski
added a commit
that referenced
this issue
Apr 1, 2021
|
Seems that test is failing again in Windows enviroments Reproduction line: Applicable branches: Reproduces locally?: Failure history: |
|
I've remuted this on |
mark-vieira
changed the title
probakowski
added a commit
that referenced
this issue
Apr 13, 2021
This change fixes number of problems in GeoIPv2 code: - closes streams from Files.list in GeoIpCli, which should fix tests on Windows - makes sure that total download time in GeoIP stats is non-negative (we serialize it as vInt which can cause problems with negative numbers and it can happen when clock was changed during operation) - fixes handling of failed/simultaneous downloads, #69951 was meant as a way to prevent 2 persistent tasks to index chunks but it would prevent any update if single download failed mid indexing, this change uses timestamp (lastUpdate) as sort of UUID. This should still prevent 2 tasks to step on each other toes (overwriting chunks) but in the end still only single task should be able to update task state (this is handled by persistent tasks framework) Closes #71145
probakowski
added a commit
to probakowski/elasticsearch
that referenced
this issue
Apr 13, 2021
This change fixes number of problems in GeoIPv2 code: - closes streams from Files.list in GeoIpCli, which should fix tests on Windows - makes sure that total download time in GeoIP stats is non-negative (we serialize it as vInt which can cause problems with negative numbers and it can happen when clock was changed during operation) - fixes handling of failed/simultaneous downloads, elastic#69951 was meant as a way to prevent 2 persistent tasks to index chunks but it would prevent any update if single download failed mid indexing, this change uses timestamp (lastUpdate) as sort of UUID. This should still prevent 2 tasks to step on each other toes (overwriting chunks) but in the end still only single task should be able to update task state (this is handled by persistent tasks framework) Closes elastic#71145 # Conflicts: # modules/ingest-geoip/src/main/java/org/elasticsearch/ingest/geoip/GeoIpDownloader.java
probakowski
added a commit
that referenced
this issue
Apr 13, 2021
* Fix problems in GeoIPv2 code (#71598) This change fixes number of problems in GeoIPv2 code: - closes streams from Files.list in GeoIpCli, which should fix tests on Windows - makes sure that total download time in GeoIP stats is non-negative (we serialize it as vInt which can cause problems with negative numbers and it can happen when clock was changed during operation) - fixes handling of failed/simultaneous downloads, #69951 was meant as a way to prevent 2 persistent tasks to index chunks but it would prevent any update if single download failed mid indexing, this change uses timestamp (lastUpdate) as sort of UUID. This should still prevent 2 tasks to step on each other toes (overwriting chunks) but in the end still only single task should be able to update task state (this is handled by persistent tasks framework) Closes #71145 # Conflicts: # modules/ingest-geoip/src/main/java/org/elasticsearch/ingest/geoip/GeoIpDownloader.java * fix compilation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Seems this is a newly added test. The
LuceneTestCasecleanup code doesn't play well here on Windows.Build scan:
https://gradle-enterprise.elastic.co/s/se7yv5fe6d4am/tests/:distribution:tools:geoip-cli:test/org.elasticsearch.geoip.GeoIpCliTests/classMethod
Reproduction line:
./gradlew.bat :distribution:tools:geoip-cli:test --tests "org.elasticsearch.geoip.GeoIpCliTests"Applicable branches:
master
Reproduces locally?:
Didn't try
Failure history:
https://gradle-enterprise.elastic.co/scans/tests?tests.container=org.elasticsearch.geoip.GeoIpCliTests&tests.test=classMethod
Failure excerpt:
The text was updated successfully, but these errors were encountered: