Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strange behavior after .percolator type deletion #7087

Closed
hovsep opened this issue Jul 30, 2014 · 2 comments · Fixed by #7091
Closed

Strange behavior after .percolator type deletion #7087

hovsep opened this issue Jul 30, 2014 · 2 comments · Fixed by #7091
Labels
>bug

Comments

@hovsep
Copy link

hovsep commented Jul 30, 2014

ES version: 1.1.1

When I remove all percolators and create new, deleted percolators are resurrected.

My test:

  1. Create empty index:

    curl -XPUT myhost:9200/myemptyindex

  2. Create two percolators:

curl -XPUT myhost:9200/myemptyindex/.percolator/1 -d '{query:{match:{t:1}}}'

curl -XPUT myhost:9200/myemptyindex/.percolator/2 -d '{query:{match:{t:2}}}'

  1. Delete all percolators:

curl -XDELETE myhost:9200/myemptyindex/.percolator

  1. Check deletion:

curl -XGET myhost:9200/myemptyindex/.percolator/_search

No percolators found.

  1. Create new percolator:

curl -XPUT myhost:9200/myemptyindex/.percolator/3 -d '{query:{match:{t:3}}}'

  1. Get all percolators:

curl -XGET myhost:9200/myemptyindex/.percolator/_search

I see deleted percolators (1,2) are resurrected, it is incorrect.

I think it may be depended on percolators caching or something like that.
@clintongormley
Copy link
Contributor

HI @hovsep

Yes, this is a known bug. Deleting a type deletes the documents within the type using delete-by-query, which doesn't unregister the in-memory percolators.

See #7052

@clintongormley
Copy link
Contributor

Depends on #7052

@martijnvg martijnvg mentioned this issue Jul 30, 2014
Merged
@martijnvg martijnvg removed the stalled label Jul 30, 2014
martijnvg added a commit to martijnvg/elasticsearch that referenced this issue Aug 11, 2014
@martijnvg
Core: Pass down the types from the delete mapping request to the dele…
2801d06 
…te by query request.

The `.percolator` type is a hidden type and therefor the types from the delete mapping request should passed down to the delete by query request, otherwise the percolator type gets ignored and the percolator queries don't get deleted from disk (only unregistered).

Closes elastic#7087
martijnvg added a commit that referenced this issue Aug 11, 2014
@martijnvg
Core: Pass down the types from the delete mapping request to the dele…
2bf63ae 
…te by query request.

The `.percolator` type is a hidden type and therefor the types from the delete mapping request should passed down to the delete by query request, otherwise the percolator type gets ignored and the percolator queries don't get deleted from disk (only unregistered).

Closes #7087
martijnvg added a commit that referenced this issue Aug 11, 2014
@martijnvg
Core: Pass down the types from the delete mapping request to the dele…
2a36042 
…te by query request.

The `.percolator` type is a hidden type and therefor the types from the delete mapping request should passed down to the delete by query request, otherwise the percolator type gets ignored and the percolator queries don't get deleted from disk (only unregistered).

Closes #7087
martijnvg added a commit that referenced this issue Sep 8, 2014
@martijnvg @areek
Core: Pass down the types from the delete mapping request to the dele…
683c663 
…te by query request.

The `.percolator` type is a hidden type and therefor the types from the delete mapping request should passed down to the delete by query request, otherwise the percolator type gets ignored and the percolator queries don't get deleted from disk (only unregistered).

Closes #7087
mute pushed a commit to mute/elasticsearch that referenced this issue Jul 29, 2015
@martijnvg
Core: Pass down the types from the delete mapping request to the dele…
62fc565 
…te by query request.

The `.percolator` type is a hidden type and therefor the types from the delete mapping request should passed down to the delete by query request, otherwise the percolator type gets ignored and the percolator queries don't get deleted from disk (only unregistered).

Closes elastic#7087
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
>bug
Projects
None yet
Milestone
No milestone
3 participants
@clintongormley @martijnvg @hovsep