Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure Reset Features API correctly resets ML configuration #69581

Closed
gwbrown opened this issue Feb 25, 2021 · 4 comments
Closed

Ensure Reset Features API correctly resets ML configuration #69581

gwbrown opened this issue Feb 25, 2021 · 4 comments
Assignees
@benwtrent
Labels
:ml Machine learning Team:ML Meta label for the ML team v7.13.0

Comments

@gwbrown
Copy link
Contributor

gwbrown commented Feb 25, 2021

While the PR that introduces the Reset Features API (#69469) includes a basic iteration of ML state cleanup, it may not be complete. This reset function should be evaluated by the ML and any shortcomings corrected if necessary.

/cc @droberts195
@gwbrown gwbrown added :ml Machine learning v7.13.0 labels Feb 25, 2021
@elasticmachine elasticmachine added the Team:ML Meta label for the ML team label Feb 25, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core (Team:ML)

@droberts195 droberts195 self-assigned this Feb 25, 2021
@gwbrown
Copy link
Contributor Author

gwbrown commented Mar 11, 2021

It's been pointed out that Transforms may need a look over as well.

@benwtrent benwtrent assigned benwtrent and unassigned droberts195 Apr 7, 2021
@benwtrent
Copy link
Member

Related PRs:

@benwtrent benwtrent mentioned this issue Apr 7, 2021
Merged
benwtrent added a commit that referenced this issue Apr 7, 2021
@benwtrent
[Transform] finalize feature reset integration (#71133)
55c7cbc 
This commit updates transform feature reset to:

- wait for transform tasks to complete
- wait for all indexing actions to transform indices to complete
- and prevents transform audit messages from being written while the reset is being processed

related to #70008 & #69581
benwtrent added a commit to benwtrent/elasticsearch that referenced this issue Apr 7, 2021
@benwtrent
[Transform] finalize feature reset integration (elastic#71133)
e7efaba 
This commit updates transform feature reset to:

- wait for transform tasks to complete
- wait for all indexing actions to transform indices to complete
- and prevents transform audit messages from being written while the reset is being processed

related to elastic#70008 & elastic#69581
@benwtrent benwtrent mentioned this issue Apr 7, 2021
Merged
benwtrent added a commit that referenced this issue Apr 7, 2021
@benwtrent
[7.x] [Transform] finalize feature reset integration (#71133) (#71425)
ec8086a 
* [Transform] finalize feature reset integration (#71133)

This commit updates transform feature reset to:

- wait for transform tasks to complete
- wait for all indexing actions to transform indices to complete
- and prevents transform audit messages from being written while the reset is being processed

related to #70008 & #69581
@benwtrent
Copy link
Member

Machine learning and transform plugins now are fully cleaned up with the reset feature API.

Following up PRs have fixed some bugs here and there, but it is looking stable right now. Closing issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benwtrent benwtrent

Labels
:ml Machine learning Team:ML Meta label for the ML team v7.13.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@gwbrown @benwtrent @droberts195 @elasticmachine