Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Transform] Enhance transform role checks #69518

Closed
6 tasks done
hendrikmuhs opened this issue Feb 24, 2021 · 2 comments
Closed
6 tasks done

[Transform] Enhance transform role checks #69518

hendrikmuhs opened this issue Feb 24, 2021 · 2 comments
Assignees
@hendrikmuhs
Labels
>enhancement :ml/Transform Transform Team:ML Meta label for the ML team

Comments

@hendrikmuhs
Copy link

hendrikmuhs commented Feb 24, 2021 •
edited
Loading

follow up #69260

#69260 fixes the most important part, deleting a transform despite the lack of a transform node. This fix gets backported as soon as possible.

This issue is a follow up to improve usability aspects, scheduled for the next release:

  • operational:
    • stats should report the correct state
    • cancel task if document could not be found / transform internal index got deleted
  • user-experience:
    • API's must better handle the case of a missing transform node
      • stats warn about no transform nodes / show number of transform nodes
      • preview should warn about no transform nodes
  • preview/validation
    • transfer validation/preview to a transform node, which ensures that the transform node is capable of handling the request
@elasticmachine elasticmachine added the Team:ML Meta label for the ML team label Feb 24, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core (Team:ML)

@hendrikmuhs hendrikmuhs self-assigned this Mar 8, 2021
@hendrikmuhs hendrikmuhs mentioned this issue Mar 9, 2021
Merged
hendrikmuhs pushed a commit to hendrikmuhs/elasticsearch that referenced this issue Mar 9, 2021
improve robustness and ux in case of a missing transform node:
ba2c7a8 
 - warn if cluster lacks a transform node in all API's (except DELETE)
 - report waiting state in stats if transform waits for assignment
 - cancel p-task on stop transform even if config has been deleted

relates elastic#69518
hendrikmuhs pushed a commit that referenced this issue Mar 10, 2021
[Transform] Enhance transform role checks (#70139)
61f0c47 
improve robustness and ux in case of a missing transform node:

 - warn if cluster lacks a transform node in all API's (except DELETE)
 - report waiting state in stats if transform waits for assignment
 - cancel p-task on stop transform even if config has been deleted

relates #69518
@hendrikmuhs hendrikmuhs mentioned this issue Mar 10, 2021
Merged
hendrikmuhs pushed a commit that referenced this issue Mar 10, 2021
[7.x][Transform] Enhance transform role checks (#70139) (#70203)
31c4adb 
improve robustness and ux in case of a missing transform node:

 - warn if cluster lacks a transform node in all API's (except DELETE)
 - report waiting state in stats if transform waits for assignment
 - cancel p-task on stop transform even if config has been deleted

relates #69518
@hendrikmuhs
Copy link
Author

the remaining redirection task was implemented in #70125

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hendrikmuhs hendrikmuhs

Labels
>enhancement :ml/Transform Transform Team:ML Meta label for the ML team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hendrikmuhs @elasticmachine