-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LdapSessionFactoryTests#testSslTrustIsReloaded failures #68995
Comments
Pinging @elastic/es-security (Team:Security) |
LdapSessionFactoryTests#testSslTrustIsReloaded relies on the resource watcher to detect the cert file overwriting. Resource watcher detects changes by only inspecting the file size on disk and the last access timestamp. For the last access timestamp, the resolution can be as low as one second depending on the JDK and the FS type. It is thus preferable to rely on file size differences in tests. Closes #68995
LdapSessionFactoryTests#testSslTrustIsReloaded relies on the resource watcher to detect the cert file overwriting. Resource watcher detects changes by only inspecting the file size on disk and the last access timestamp. For the last access timestamp, the resolution can be as low as one second depending on the JDK and the FS type. It is thus preferable to rely on file size differences in tests. Closes elastic#68995
LdapSessionFactoryTests#testSslTrustIsReloaded relies on the resource watcher to detect the cert file overwriting. Resource watcher detects changes by only inspecting the file size on disk and the last access timestamp. For the last access timestamp, the resolution can be as low as one second depending on the JDK and the FS type. It is thus preferable to rely on file size differences in tests. Closes elastic#68995
LdapSessionFactoryTests#testSslTrustIsReloaded relies on the resource watcher to detect the cert file overwriting. Resource watcher detects changes by only inspecting the file size on disk and the last access timestamp. For the last access timestamp, the resolution can be as low as one second depending on the JDK and the FS type. It is thus preferable to rely on file size differences in tests. Closes #68995
LdapSessionFactoryTests#testSslTrustIsReloaded relies on the resource watcher to detect the cert file overwriting. Resource watcher detects changes by only inspecting the file size on disk and the last access timestamp. For the last access timestamp, the resolution can be as low as one second depending on the JDK and the FS type. It is thus preferable to rely on file size differences in tests. Closes #68995
This is still failing on the 6.8 branch. |
These are different failures fall into two categories. The first is due to TLS 1.0 and 1.1 gets disabled in latest JDK releases, which is the same issue as #72877. I muted the fail tests.
The second is the same as #72359. Albert muted a few with #72529 (different tests but same error message), but apparently there are more.
But somehow they do not fail for 7.x. Did we apply some gradle magic for 7.x branches? @mark-vieira |
I don't believe so. It's possible some 6.8 specific configuration go lost here but I'm not sure what it would be. Is there extra configuration that should have been around for the older branches to get these tests to pass? Or were we just not running them at all? |
The remaining of the failures are 6.8 specific only and this has been muted in 6.8. I'm going to close this as won't fix since 6.8 is EOL |
This fails in 7.x, 7.11, 6.8
Build scan:
https://gradle-enterprise.elastic.co/s/fdaeh2nciqjwg/console-log?task=:x-pack:plugin:security:unitTest
https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+pull-request-2/695/testReport/junit/org.elasticsearch.xpack.security.authc.ldap/LdapSessionFactoryTests/testSslTrustIsReloaded/
Repro line:
Reproduces locally?:
No
Applicable branches:
7.x, 7.11, 6.8
Failure history:
It started failing upon attempting to backport #68985
Failure excerpt:
Expected exception is not thrown.
The text was updated successfully, but these errors were encountered: