-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Painless: improve error message when parameter must be a constant but isn't #68324
Comments
Pinging @elastic/es-core-infra (Team:Core/Infra) |
Yes this message should be better. @nik9000 can you provide a brief script illustrating the problem? |
In a runtime field if you do something like:
Which, I think, will reply with something like: "all arguments must be constant but the [1] argument isn't" |
Hi, can I check this out? First time contributing |
Hi @nik9000, i opened a PR to solve this issue and since this is my first contribution, i'd be really glad if you could give me some feedback. |
Hi @nik9000, could you tell me what do you think of these new error messages? I had mapped four occurrences of this type of error, but please let me know if i forgot to update any other messages. |
Could I jump on this issue? I'm going to optimize the error message to:
|
@Kxrr, That'd be a good message |
Hi @stu-elastic, could you please review my changes in #82638 |
Now the error message is:
That isn't really even English. I mean, it tells you where to look and we don't have any better ideas given the infrastructure we have, but we do need to make it better.
The text was updated successfully, but these errors were encountered: