Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should we include a category with deprecation messages? #64824

Closed
pugnascotia opened this issue Nov 9, 2020 · 2 comments · Fixed by #67443
Closed

Should we include a category with deprecation messages? #64824

pugnascotia opened this issue Nov 9, 2020 · 2 comments · Fixed by #67443
Assignees
@pugnascotia
Labels
:Core/Infra/Logging Log management and logging utilities >enhancement Team:Core/Infra Meta label for core/infra team v7.12.0 v8.0.0-alpha1

Comments

@pugnascotia
Copy link
Contributor

Right now, the deprecation messages that Elasticsearch records contain a "key" (a string identifier, loosely descriptive) and a message about the deprecation, possibly with specific details.

We discussed during an 8.0 Stack Upgrade meeting whether it would be useful to also record a category field, e.g. "search" or "security". This would provide a useful field for grouping messages in the Kibana Upgrade Assistant. Such groupings would be useful for prioritising efforts to address deprecated uses of Elasticsearch, or even assigning work to different groups.

The work to implement this would be simple enough, just a little tedious.
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (:Core/Infra/Logging)

@elasticmachine elasticmachine added the Team:Core/Infra Meta label for core/infra team label Nov 9, 2020
@rjernst rjernst added the needs:triage Requires assignment of a team area label label Dec 3, 2020
@pgomulka pgomulka removed the needs:triage Requires assignment of a team area label label Dec 10, 2020
@pugnascotia pugnascotia self-assigned this Jan 6, 2021
@rjernst
Copy link
Member

rjernst commented Jan 12, 2021

We discussed this within core/infra and it seems easy enough and not to much overhead, given a fixed set of categories and requiring that when logging a deprecating message.

@pugnascotia pugnascotia mentioned this issue Jan 13, 2021
Merged
pugnascotia added a commit that referenced this issue Jan 18, 2021
@pugnascotia
Introduce deprecation categories (#67443)
1a05a5a 
Closes #64824. Introduce the concept of categories to deprecation
logging. Every location where we log a deprecation message must now
include a deprecation category.
pugnascotia added a commit to pugnascotia/elasticsearch that referenced this issue Jan 27, 2021
@pugnascotia
Introduce deprecation categories
247ae6b 
Sort-of backport of elastic#67443.

Closes elastic#64824. Introduce the concept of categories to deprecation
logging. Every location where we log a deprecation message must now
include a deprecation category.
@pugnascotia pugnascotia mentioned this issue Jan 27, 2021
Merged
pugnascotia added a commit that referenced this issue Jan 29, 2021
@pugnascotia
Introduce deprecation categories (#68061)
1c5b89c 
Sort-of backport of #67443.

Closes #64824. Introduce the concept of categories to deprecation
logging. Every location where we log a deprecation message must now
include a deprecation category.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pugnascotia pugnascotia

Labels
:Core/Infra/Logging Log management and logging utilities >enhancement Team:Core/Infra Meta label for core/infra team v7.12.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Introduce deprecation categories pugnascotia/elasticsearch
5 participants
@rjernst @jakelandis @pugnascotia @pgomulka @elasticmachine