Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Followup for #62490 to address all the comments #63792

Closed
BigPandaToo opened this issue Oct 16, 2020 · 0 comments · Fixed by #63797
Closed

Followup for #62490 to address all the comments #63792

BigPandaToo opened this issue Oct 16, 2020 · 0 comments · Fixed by #63797

Comments

@BigPandaToo
Copy link
Contributor

See #62490 (comment)
for the last comments to address

@BigPandaToo BigPandaToo self-assigned this Oct 16, 2020
BigPandaToo added a commit to BigPandaToo/elasticsearch that referenced this issue Oct 16, 2020
BigPandaToo added a commit to BigPandaToo/elasticsearch that referenced this issue Oct 16, 2020
BigPandaToo added a commit that referenced this issue Oct 16, 2020
* Nit fixes and formatting following #62490 comments

Resolves: #63792

* Nit fixes and formatting following #62490 comments

Resolves: #63792

* Nit fixes and formatting following #62490 comments
Fixing username

* Nit fixes and formatting following #62490 comments
Fixing formatting
BigPandaToo added a commit to BigPandaToo/elasticsearch that referenced this issue Oct 16, 2020
)

* Nit fixes and formatting following elastic#62490 comments

Resolves: elastic#63792

* Nit fixes and formatting following elastic#62490 comments

Resolves: elastic#63792

* Nit fixes and formatting following elastic#62490 comments
Fixing username

* Nit fixes and formatting following elastic#62490 comments
Fixing formatting
BigPandaToo added a commit that referenced this issue Oct 16, 2020
#63841)

* Adding authentication information to access token create APIs (#62490)

* Adding authentication information to access token create APIs

Adding authentication object to following APIs:
/_security/oauth2/token
/_security/delegate_pki
/_security/saml/authenticate
/_security/oidc/authenticate

Resolves: #59685
(cherry picked from commit 51dbd9e)

* Addressing PR commends, fixing tests

* Returning tokenGroups attribute as SID string instead of byte array (AD metadata)

Addressing PR comments

* Returning tokenGroups attribute as SID string instead of byte array (AD metadata)

Update version check

* Returning tokenGroups attribute as SID string instead of byte array (AD metadata)

Update version check

* Addressing more PR comments

* Adding more to integration tests + some small fixes

* Nit fixes and formatting following #62490 comments (#63797)

* Nit fixes and formatting following #62490 comments

Resolves: #63792

* Nit fixes and formatting following #62490 comments

Resolves: #63792

* Nit fixes and formatting following #62490 comments
Fixing username

* Nit fixes and formatting following #62490 comments
Fixing formatting

* Fixing merge conflicts

* Fixing merge conflicts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants