Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for value counts to rate aggregation #63575

Closed
imotov opened this issue Oct 12, 2020 · 1 comment · Fixed by #63687
Closed

Add support for value counts to rate aggregation #63575

imotov opened this issue Oct 12, 2020 · 1 comment · Fixed by #63687
Assignees
@imotov
Labels
:Analytics/Aggregations Aggregations >enhancement Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo)

Comments

@imotov
Copy link
Contributor

imotov commented Oct 12, 2020

In #63289 we added support for histogram fields to rate aggregations. The histogram fields contains both sum of the values and value count. In #63289 we only added support for sum, we should also add support for value count. This support can be extended for numeric fields as well.
@imotov imotov self-assigned this Oct 12, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo (:Analytics/Aggregations)

@elasticmachine elasticmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Oct 12, 2020
@imotov imotov mentioned this issue Oct 14, 2020
Merged
imotov added a commit that referenced this issue Oct 15, 2020
@imotov
Add value_count mode to rate agg (#63687)
e6c70f6 
Adds a new value count mode to the rate aggregation.

Closes #63575
@imotov imotov mentioned this issue Oct 16, 2020
Merged
imotov added a commit to imotov/elasticsearch that referenced this issue Oct 16, 2020
@imotov
Update serialization version after backport
f297062 
Updates serialization version after the backport of elastic#63847

Relates to elastic#63575
@imotov imotov mentioned this issue Oct 16, 2020
Merged
imotov added a commit that referenced this issue Oct 19, 2020
@imotov
Add value_count mode to rate agg (#63687) (#63847)
5ebe90d 
Adds a new value count mode to the rate aggregation.

Closes #63575
imotov added a commit that referenced this issue Oct 19, 2020
@imotov
Update serialization version after backport (#63848)
6ab73cd 
Updates serialization version after the backport of #63847

Relates to #63575
@stevejgordon stevejgordon mentioned this issue Dec 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@imotov imotov

Labels
:Analytics/Aggregations Aggregations >enhancement Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add value_count mode to rate agg imotov/elasticsearch
2 participants
@imotov @elasticmachine