Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Reproducible Failure in InternalAutoDateHistogramTests.testReduceRandom #59131

Closed
iverase opened this issue Jul 7, 2020 · 2 comments
Closed

[CI] Reproducible Failure in InternalAutoDateHistogramTests.testReduceRandom #59131

iverase opened this issue Jul 7, 2020 · 2 comments
Assignees
@nik9000
Labels
:Analytics/Aggregations Aggregations Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test-failure Triaged test failures from CI

Comments

@iverase
Copy link
Contributor

iverase commented Jul 7, 2020 •
edited
Loading

This test failed in one of my PR and can be reproduce:

./gradlew ':server:test' --tests "org.elasticsearch.search.aggregations.bucket.histogram.InternalAutoDateHistogramTests.testReduceRandom" -Dtests.seed=5E4CFF4B6A47B19C -Dtests.security.manager=true -Dtests.locale=ar-YE -Dtests.timezone=Asia/Krasnoyarsk

Error:

java.lang.IllegalArgumentException: [9223372034176375807] must be <= [0]
        at __randomizedtesting.SeedInfo.seed([5E4CFF4B6A47B19C:9E71535A4C1A28CA]:0)
        at org.elasticsearch.common.LocalTimeOffset.lookup(LocalTimeOffset.java:61)
        at org.elasticsearch.common.Rounding$TimeUnitRounding.prepare(Rounding.java:419)
        at org.elasticsearch.search.aggregations.bucket.histogram.InternalAutoDateHistogramTests.assertReduced(InternalAutoDateHistogramTests.java:157)
@iverase iverase added >test-failure Triaged test failures from CI :Analytics/Aggregations Aggregations labels Jul 7, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo (:Analytics/Aggregations)

@elasticmachine elasticmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Jul 7, 2020
@iverase iverase changed the title [CI] InternalAutoDateHistogramTests.testReduceRandom fails reproducibl [CI] Reproducible Failure in InternalAutoDateHistogramTests.testReduceRandom Jul 7, 2020
@nik9000 nik9000 self-assigned this Jul 7, 2020
@nik9000
Copy link
Member

nik9000 commented Jul 7, 2020

Sounds like it is my bug.

@nik9000 nik9000 closed this as completed in 0de3c9a Jul 7, 2020
nik9000 added a commit that referenced this issue Jul 7, 2020
@nik9000
Fix test bug in auto_date_histo
d536854 
The test would try to prepare a `Rounding` even when there aren't any
buckets. This would fail because there is no range over which to prepare
the rounding. It turns out that we don't need the rounding in that case
so we just use `null` then.

Closes #59131
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nik9000 nik9000

Labels
:Analytics/Aggregations Aggregations Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test-failure Triaged test failures from CI
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nik9000 @elasticmachine @iverase