Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test failure: org.elasticsearch.xpack.searchablesnapshots.rest.FsSearchableSnapshotsIT #58961

Closed
jakelandis opened this issue Jul 2, 2020 · 3 comments
Closed

Test failure: org.elasticsearch.xpack.searchablesnapshots.rest.FsSearchableSnapshotsIT #58961

jakelandis opened this issue Jul 2, 2020 · 3 comments
Assignees
@tlrx
Labels
:Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. >test-failure Triaged test failures from CI

Comments

@jakelandis
Copy link
Contributor

More specifically it seems that tests from :x-pack:plugin:searchable-snapshots:qa:rest:integTest in 7.x and 7.8 are susceptible to failing.

Build scan:

7.8 https://gradle-enterprise.elastic.co/s/lbxrrtqjia4oe (FsSearchableSnapshotsIT and SearchableSnapshotsClientYamlTestSuiteIT failures) (includes commit a6347a8 and ec4843f)
7.x https://gradle-enterprise.elastic.co/s/qjbdm6lqgwjqo (FsSearchableSnapshotsIT failures) (includes commit 6aa669c and ec4843f)

Repro line:
Focusing on FsSearchableSnapshotsIT since they seem to be the common denomiator (and relevant to recent changes)

REPRODUCE WITH: ./gradlew ':x-pack:plugin:searchable-snapshots:qa:rest:integTestRunner' --tests "org.elasticsearch.xpack.searchablesnapshots.rest.FsSearchableSnapshotsIT.testClearCache" -Dtests.seed=730DE50376F77A10 -Dtests.security.manager=true -Dtests.locale=ar-EG -Dtests.timezone=Africa/Kigali -Druntime.java=8

Reproduces locally?:
No. Tried multiple times with different reproduction lines and running different snapshot based tests in parallel.

Applicable branches:

It seems 7.x and 7.8

Failure history:

History is skewed by some related changes #58847 and #58912

Failure excerpt:

org.elasticsearch.xpack.searchablesnapshots.rest.FsSearchableSnapshotsIT > testClearCache FAILED
    org.elasticsearch.client.ResponseException: method [POST], host [http://127.0.0.1:35474], URI [/_snapshot/repository/searchable-snapshot/_mount?wait_for_completion=true], status line [HTTP/1.1 500 Internal Server Error]
    {"error":{"root_cause":[{"type":"snapshot_restore_exception","reason":"[repository:searchable-snapshot/4gHSfhgjS8Gtpt48i7shHQ] cannot restore index [wbhjbjxkmn] because an open index with same name already exists in the cluster. Either close or delete the existing index or restore the index under a different name by providing a rename pattern and replacement name"}],"type":"snapshot_restore_exception","reason":"[repository:searchable-snapshot/4gHSfhgjS8Gtpt48i7shHQ] cannot restore index [wbhjbjxkmn] because an open index with same name already exists in the cluster. Either close or delete the existing index or restore the index under a different name by providing a rename pattern and replacement name"},"status":500}

cc: @tlrx
related: #58901
@jakelandis jakelandis added :Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs >test-failure Triaged test failures from CI labels Jul 2, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (:Distributed/Snapshot/Restore)

@elasticmachine elasticmachine added the Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. label Jul 2, 2020
@tlrx tlrx self-assigned this Jul 3, 2020
@pgomulka
Copy link
Contributor

pgomulka commented Jul 3, 2020

It happened again https://gradle-enterprise.elastic.co/s/dd5oniyis7nna on 7.8

@tlrx tlrx mentioned this issue Jul 3, 2020
Merged
tlrx added a commit that referenced this issue Jul 5, 2020
@tlrx
Check acknowledged responses in FsSearchableSnapshotsIT (#59021)
0c2b689 
Despite all my attempts I did not manage to reproduce issues like the ones 
described in #58961. My guess is that the _mount request got retried at 
some point but I wasn't able to validate this assumption.

Still, the FsSearchableSnapshotsIT can be pretty disk heavy if a small 
random chunk size and a large number of documents is picked up in the 
tests. The parent class also does not verify the acknowledged status 
of some requests.

This commit lowers down the chunk size and number of docs in tests 
(this is extensively tests in unit tests) and also adds assertions on 
acknowledged responses.

Relates #58961
tlrx added a commit that referenced this issue Jul 5, 2020
@tlrx
Check acknowledged responses in FsSearchableSnapshotsIT (#59021)
0e17654 
Despite all my attempts I did not manage to reproduce issues like the ones 
described in #58961. My guess is that the _mount request got retried at 
some point but I wasn't able to validate this assumption.

Still, the FsSearchableSnapshotsIT can be pretty disk heavy if a small 
random chunk size and a large number of documents is picked up in the 
tests. The parent class also does not verify the acknowledged status 
of some requests.

This commit lowers down the chunk size and number of docs in tests 
(this is extensively tests in unit tests) and also adds assertions on 
acknowledged responses.

Relates #58961
tlrx added a commit that referenced this issue Jul 5, 2020
@tlrx
Check acknowledged responses in FsSearchableSnapshotsIT (#59021)
49f4227 
Despite all my attempts I did not manage to reproduce issues like the ones 
described in #58961. My guess is that the _mount request got retried at 
some point but I wasn't able to validate this assumption.

Still, the FsSearchableSnapshotsIT can be pretty disk heavy if a small 
random chunk size and a large number of documents is picked up in the 
tests. The parent class also does not verify the acknowledged status 
of some requests.

This commit lowers down the chunk size and number of docs in tests 
(this is extensively tests in unit tests) and also adds assertions on 
acknowledged responses.

Relates #58961
@tlrx
Copy link
Member

tlrx commented Jul 15, 2020

The test didn't fail in the past 7 days since #59021 has been merged. Another change in #59313 addresses the last failure that happened on 7.8. I'm considering this issue as fixed.

@tlrx tlrx closed this as completed Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tlrx tlrx

Labels
:Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. >test-failure Triaged test failures from CI
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@tlrx @jakelandis @pgomulka @elasticmachine