Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Experimental feature: variable_width_histogram #58573

Closed
nik9000 opened this issue Jun 25, 2020 · 2 comments · Fixed by #66055
Closed

Experimental feature: variable_width_histogram #58573

nik9000 opened this issue Jun 25, 2020 · 2 comments · Fixed by #66055
Labels
:Analytics/Aggregations Aggregations experimental/beta Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo)

Comments

@nik9000
Copy link
Member

nik9000 commented Jun 25, 2020 •
edited
Loading

In #42035 @jamesdorfman added a neat new kind of aggregations which performs similarly to a regular histogram but instead to specifying the width of each bucket you specify how many buckets you'd like, kind of like the auto_date_histogram. Unlike auto_date_histogram, variable_width_histogram's buckets have, well, variable width. The particulars of its algorithm mean that the buckets won't necessarily have the same number of documents in them. Instead it tries to preserve the shape of the data. When it has to merge buckets together it merges the buckets that are closest together already.

This is an interesting and new aggregation, and, frankly, we're not sure that we've really thought through the interface all the way. So we'd like some feedback on it and some time to be able to make breaking changes to its request and/or response. This, we're marking it experimental. Our plan to remove experimental is to have a few folks take a look at it and comment.
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo (:Analytics/Aggregations)

@elasticmachine elasticmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Jun 25, 2020
@nik9000 nik9000 mentioned this issue Jun 25, 2020
Merged
nik9000 added a commit to nik9000/elasticsearch that referenced this issue Jun 25, 2020
@nik9000
Docs: Mark variable_width_histogram experimental
4216eb4 
We're tracking this aggregation's experimental-progress in elastic#58573. We'd
like a little time to be able to make backwards incompatible changes to
the aggregation because we're not 100% sure about the request and
response format yet.
nik9000 added a commit that referenced this issue Jun 25, 2020
@nik9000
Docs: Mark variable_width_histogram experimental (#58574)
dda78ff 
We're tracking this aggregation's experimental-progress in #58573. We'd
like a little time to be able to make backwards incompatible changes to
the aggregation because we're not 100% sure about the request and
response format yet.
nik9000 added a commit that referenced this issue Jun 25, 2020
@nik9000
Docs: Mark variable_width_histogram experimental (#58574)
d22a242 
We're tracking this aggregation's experimental-progress in #58573. We'd
like a little time to be able to make backwards incompatible changes to
the aggregation because we're not 100% sure about the request and
response format yet.
@nik9000
Copy link
Member Author

nik9000 commented Jun 26, 2020

We should almost certainly fix variable_width_histogram when it attempts to collect from many buckets, as described in #58619.

@russcam russcam mentioned this issue Jul 28, 2020
Closed
29 tasks
@wylieconlon wylieconlon mentioned this issue Aug 4, 2020
Closed
nik9000 added a commit to nik9000/elasticsearch that referenced this issue Dec 8, 2020
@nik9000
Drop experimental from variable width histogram
97350c5 
Its been several months and we haven't bumped into any good reason to
rework the variable width histogram. So let's drop experimental from it!

Closes elastic#58573
@nik9000 nik9000 mentioned this issue Dec 8, 2020
Merged
nik9000 added a commit that referenced this issue Dec 8, 2020
@nik9000
Drop experimental from variable width histogram (#66055)
524f39f 
Its been several months and we haven't bumped into any good reason to
rework the variable width histogram. So let's drop experimental from it!

Closes #58573
nik9000 added a commit to nik9000/elasticsearch that referenced this issue Dec 8, 2020
@nik9000
Drop experimental from variable width histogram (elastic#66055)
7cd830b 
Its been several months and we haven't bumped into any good reason to
rework the variable width histogram. So let's drop experimental from it!

Closes elastic#58573
@nik9000 nik9000 mentioned this issue Dec 8, 2020
Merged
nik9000 added a commit that referenced this issue Dec 8, 2020
@nik9000
Drop experimental from variable width histogram (backport of #66055) (#…
d13c4b3 
…66060)

Its been several months and we haven't bumped into any good reason to
rework the variable width histogram. So let's drop experimental from it!

Closes #58573
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
:Analytics/Aggregations Aggregations experimental/beta Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Drop experimental from variable width histogram nik9000/elasticsearch
2 participants
@nik9000 @elasticmachine