Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wildcard field should return value as Strings not ByteRefs for scripts #58044

Closed
markharwood opened this issue Jun 12, 2020 · 2 comments · Fixed by #58060
Closed

Wildcard field should return value as Strings not ByteRefs for scripts #58044

markharwood opened this issue Jun 12, 2020 · 2 comments · Fixed by #58060
Assignees
@markharwood
Labels
>bug :Search/Search Search-related issues that do not fall into other categories Team:Search Meta label for search team

Comments

@markharwood
Copy link
Contributor

To support compatibility with keyword fields the wildcard field should return Strings for values to scripts, not a BytesRef object (currently a ScriptDocValues to be more precise)
@markharwood markharwood added >bug :Search/Search Search-related issues that do not fall into other categories labels Jun 12, 2020
@markharwood markharwood self-assigned this Jun 12, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (:Search/Search)

@elasticmachine elasticmachine added the Team:Search Meta label for search team label Jun 12, 2020
@markharwood markharwood mentioned this issue Jun 12, 2020
Merged
@astefan astefan mentioned this issue Jun 12, 2020
Merged
markharwood added a commit to markharwood/elasticsearch that referenced this issue Jun 15, 2020
@markharwood
Fix for wildcard fields that returned ByteRefs not Strings to scripts.
0ef85cf 
This need some reorg of BinaryDV field data classes to allow specialisation of scripted doc values.
Moved common logic to a new abstract base class and added a new subclass to return string-based representations to scripts.

Closes elastic#58044
markharwood added a commit that referenced this issue Jun 15, 2020
@markharwood
Fix for wildcard fields that returned ByteRefs not Strings to scripts. (
33fe44c 
#58060)

This need some reorg of BinaryDV field data classes to allow specialisation of scripted doc values.
Moved common logic to a new abstract base class and added a new subclass to return string-based representations to scripts.

Closes #58044
markharwood added a commit to markharwood/elasticsearch that referenced this issue Jun 15, 2020
@markharwood
Fix for wildcard fields that returned ByteRefs not Strings to scripts. (
bc59078 
elastic#58060)

This need some reorg of BinaryDV field data classes to allow specialisation of scripted doc values.
Moved common logic to a new abstract base class and added a new subclass to return string-based representations to scripts.

Closes elastic#58044
@markharwood markharwood mentioned this issue Jun 15, 2020
Merged
@jimczi jimczi mentioned this issue Jun 15, 2020
Closed
markharwood added a commit that referenced this issue Jun 15, 2020
@markharwood
Fix for wildcard fields that returned ByteRefs not Strings to scripts. (
03dd73d 
#58060) (#58109)

This need some reorg of BinaryDV field data classes to allow specialisation of scripted doc values.
Moved common logic to a new abstract base class and added a new subclass to return string-based representations to scripts.

Closes #58044
@markharwood
Copy link
Contributor Author

Thanks for reporting this, @astefan

@russcam russcam mentioned this issue Jul 23, 2020
Closed
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@markharwood markharwood

Labels
>bug :Search/Search Search-related issues that do not fall into other categories Team:Search Meta label for search team
Projects
None yet
Milestone
No milestone
2 participants
@markharwood @elasticmachine