Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Transform] remove transform remote connect #54179

Closed
hendrikmuhs opened this issue Mar 25, 2020 · 2 comments · Fixed by #54217
Closed

[Transform] remove transform remote connect #54179

hendrikmuhs opened this issue Mar 25, 2020 · 2 comments · Fixed by #54217
Assignees
@benwtrent
Labels
:ml/Transform Transform >non-issue

Comments

@hendrikmuhs
Copy link

The late addition: #53924
introduces the ability to query for nodes that can connect to remote clusters.

This makes TRANSFORM_REMOTE_ENABLED_NODE_ATTR introduced in #52712 superflous. Because #52712 targets 7.7, which means unreleased, it makes sense to remove the setting for 7.7 to circumvent a deprecation cycle.

This should go in, into 7.7 despite FF, the change is low risk.

/CC @jasontedor @droberts195

(There seems no appropriate label, using >non-issue for now as its unreleased und should not be picked up for release notes.)
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core (:ml/Transform)

@jasontedor
Copy link
Member

This sounds good to me!

@benwtrent benwtrent self-assigned this Mar 25, 2020
@benwtrent benwtrent mentioned this issue Mar 25, 2020
Merged
benwtrent added a commit that referenced this issue Mar 25, 2020
@benwtrent
[Transform] Remove node.attr.transform.remote_connect and use new rem…
202b4fb 
…ote cluster client node role (#54217)

With the addition of a formal role for nodes indicating remote cluster connection, the transform specific attribute `node.attr.transform.remote_connect` is no longer necessary.

closes #54179
benwtrent added a commit to benwtrent/elasticsearch that referenced this issue Mar 25, 2020
@benwtrent
[Transform] Remove node.attr.transform.remote_connect and use new rem…
66127d0 
…ote cluster client node role (elastic#54217)

With the addition of a formal role for nodes indicating remote cluster connection, the transform specific attribute `node.attr.transform.remote_connect` is no longer necessary.

closes elastic#54179
benwtrent added a commit to benwtrent/elasticsearch that referenced this issue Mar 25, 2020
@benwtrent
[Transform] Remove node.attr.transform.remote_connect and use new rem…
151d05b 
…ote cluster client node role (elastic#54217)

With the addition of a formal role for nodes indicating remote cluster connection, the transform specific attribute `node.attr.transform.remote_connect` is no longer necessary.

closes elastic#54179
benwtrent added a commit that referenced this issue Mar 25, 2020
@benwtrent
[Transform] Remove node.attr.transform.remote_connect and use new rem…
6d68cf8 
…ote cluster client node role (#54217) (#54224)

With the addition of a formal role for nodes indicating remote cluster connection, the transform specific attribute `node.attr.transform.remote_connect` is no longer necessary.

closes #54179
benwtrent added a commit that referenced this issue Mar 25, 2020
@benwtrent
[Transform] Remove node.attr.transform.remote_connect and use new rem…
7e3bbdf 
…ote cluster client node role (#54217) (#54226)

With the addition of a formal role for nodes indicating remote cluster connection, the transform specific attribute `node.attr.transform.remote_connect` is no longer necessary.

closes #54179
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benwtrent benwtrent

Labels
:ml/Transform Transform >non-issue
Projects
None yet
Milestone
No milestone
4 participants
@benwtrent @jasontedor @hendrikmuhs @elasticmachine