-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically configure formatting for IntelliJ #53812
Comments
Pinging @elastic/es-core-infra (:Core/Infra/Build) |
@pugnascotia does the recent work for Checkstyle mostly address this? |
No, this is a separate thing. |
Where did we land with this? So far as I can tell the only missing bit is the "Required plugins" bit. I tested this locally by uninstalling the plugin and doing a fresh import and it worked fine. I suggest we go ahead and do this so it's one less thing folks have to configure manually. In fact, I think that will mean folks don't have to configure anything manually on import which would be awesome. I know we've had some reports of folks fighting with spotless before realizing they weren't using the same format rules in the IDE. |
I haven't looked at this again since I raised it, but if you can get it to work on project import then please do! |
Should we add the checkstyle plugin to the list as well? |
Closes elastic#53812. The CheckStyle-IDEA and EcliseCodeFormatter IDEA plugins are to all intents and purposes required when using IntelliJ to work on Elasticsearch, so add configuration that marks then as required.
Closes #53812. The CheckStyle-IDEA and EcliseCodeFormatter IDEA plugins are to all intents and purposes required when using IntelliJ to work on Elasticsearch, so add configuration that marks then as required.
Closes #53812. The CheckStyle-IDEA and EcliseCodeFormatter IDEA plugins are to all intents and purposes required when using IntelliJ to work on Elasticsearch, so add configuration that marks then as required.
Closes #53812. The CheckStyle-IDEA and EcliseCodeFormatter IDEA plugins are to all intents and purposes required when using IntelliJ to work on Elasticsearch, so add configuration that marks then as required.
Closes #53812. The CheckStyle-IDEA and EcliseCodeFormatter IDEA plugins are to all intents and purposes required when using IntelliJ to work on Elasticsearch, so add configuration that marks then as required.
Forked from #53747.
We could automatically configure IntelliJ to use the Eclipse formatter and our bundled format config. The downside of this is that it relies on the "Eclipse Code Formatter" plugin, though I also noticed a thing in IntelliJ about "Required Plugins", under "Build, Execution, Deployment". I tried adding the Eclipse plugin, and it created the file
.idea/externalDependencies.xml
with the following content:Configuring the plugin created:
.idea/eclipseCodeFormatter.xml
with contents:It's also referenced in
.idea/workspace.xml
:The text was updated successfully, but these errors were encountered: