Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugin development - extra REST tests are executed #53183

Closed
jakelandis opened this issue Mar 5, 2020 · 1 comment · Fixed by #53184
Closed

Plugin development - extra REST tests are executed #53183

jakelandis opened this issue Mar 5, 2020 · 1 comment · Fixed by #53184
Labels
>bug :Core/Infra/Plugins Plugin API and infrastructure

Comments

@jakelandis
Copy link
Contributor

Starting with 7.6.1 some internal changes to how the REST tests are managed accidentally causes all of the REST tests (not just the plugin tests) to execute. This applies to any plugin that uses the REST test framework from build-tools. The plugin REST tests are still run.

The workaround is to add the following to build.gradle after applying the plugins:

restResources {
  restApi {
    includeCore '*'
  }
}
@jakelandis jakelandis added >bug :Core/Infra/Plugins Plugin API and infrastructure labels Mar 5, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (:Core/Infra/Plugins)

@jakelandis jakelandis mentioned this issue Mar 5, 2020
Merged
jakelandis added a commit that referenced this issue Mar 5, 2020
@jakelandis
Ensure only plugin REST tests are run for plugins (#53184)
484372a 
This commit fixes ensures that for external builds
(e.g. plugin development) that the REST tests that are
copied are properly filtered to only include the API
by default.

The code prior to this change resulted in including both
the API and tests since the copy.include resulted as an
empty list by default since the stream is empty unless
explicitly configured.

related #52114
fixes #53183
jakelandis added a commit to jakelandis/elasticsearch that referenced this issue Mar 5, 2020
@jakelandis
Ensure only plugin REST tests are run for plugins (elastic#53184)
d2cdd17 
This commit fixes ensures that for external builds
(e.g. plugin development) that the REST tests that are
copied are properly filtered to only include the API
by default.

The code prior to this change resulted in including both
the API and tests since the copy.include resulted as an
empty list by default since the stream is empty unless
explicitly configured.

related elastic#52114
fixes elastic#53183
jakelandis added a commit to jakelandis/elasticsearch that referenced this issue Mar 5, 2020
@jakelandis
Ensure only plugin REST tests are run for plugins (elastic#53184)
2d338ed 
This commit fixes ensures that for external builds
(e.g. plugin development) that the REST tests that are
copied are properly filtered to only include the API
by default.

The code prior to this change resulted in including both
the API and tests since the copy.include resulted as an
empty list by default since the stream is empty unless
explicitly configured.

related elastic#52114
fixes elastic#53183
jakelandis added a commit that referenced this issue Mar 5, 2020
@jakelandis
[7.x] Ensure only plugin REST tests are run for plugins (#5318… (#53196)
6a5d919 
This commit fixes ensures that for external builds
(e.g. plugin development) that the REST tests that are
copied are properly filtered to only include the API
by default.

The code prior to this change resulted in including both
the API and tests since the copy.include resulted as an
empty list by default since the stream is empty unless
explicitly configured.

related #52114
fixes #53183
jakelandis added a commit that referenced this issue Mar 5, 2020
@jakelandis
[7.6] Ensure only plugin REST tests are run for plugins (#5318… (#53197)
23d599d 
This commit fixes ensures that for external builds
(e.g. plugin development) that the REST tests that are
copied are properly filtered to only include the API
by default.

The code prior to this change resulted in including both
the API and tests since the copy.include resulted as an
empty list by default since the stream is empty unless
explicitly configured.

related #52114
fixes #53183
@codebrain codebrain mentioned this issue Apr 1, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
>bug :Core/Infra/Plugins Plugin API and infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ensure only plugin REST tests are run for plugins jakelandis/elasticsearch
2 participants
@jakelandis @elasticmachine