Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link the flattened field from the kv processor and nested fields #52239

Closed
jpountz opened this issue Feb 11, 2020 · 3 comments · Fixed by #56794
Closed

Link the flattened field from the kv processor and nested fields #52239

jpountz opened this issue Feb 11, 2020 · 3 comments · Fixed by #56794
Assignees
@lockewritesdocs
Labels
>docs General docs changes :Search Foundations/Mapping Index mappings, including merging and defining field types Team:Docs Meta label for docs team Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch

Comments

@jpountz
Copy link
Contributor

jpountz commented Feb 11, 2020

I think we should try to make flattened more easily discoverable in our docs. I'm currently considering linking from:

  • The kv processor because it is one reason how users may end up with field names they don't have control of.
  • The nested field because whenever users are tempted to create nested objects that have two key and value keyword fields, then it's likely a better fit for the flattened field.

Any other ideas where we should link flattened from?
@jpountz jpountz added >docs General docs changes :Search Foundations/Mapping Index mappings, including merging and defining field types labels Feb 11, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (>docs)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (:Search/Mapping)

@rjernst rjernst added Team:Docs Meta label for docs team Team:Search Meta label for search team labels May 4, 2020
@jrodewig jrodewig assigned jrodewig and unassigned jrodewig May 11, 2020
@lockewritesdocs lockewritesdocs self-assigned this May 14, 2020
@lockewritesdocs
Copy link
Contributor

I think we should try to make flattened more easily discoverable in our docs. I'm currently considering linking from:

  • The kv processor because it is one reason how users may end up with field names they don't have control of.
  • The nested field because whenever users are tempted to create nested objects that have two key and value keyword fields, then it's likely a better fit for the flattened field.

Any other ideas where we should link flattened from?

Adding some links to the sections that Adrien mentioned.

lockewritesdocs pushed a commit to lockewritesdocs/elasticsearch that referenced this issue May 14, 2020
Changes for elastic#52239.
9bb9814
@lockewritesdocs lockewritesdocs mentioned this issue May 14, 2020
Merged
lockewritesdocs pushed a commit that referenced this issue May 19, 2020
@jrodewig
[DOCS] Add links to flattened datatype (#56794)
d77388f 
* Changes for #52239.

* Incorporating review feedback from Julie T. Also single-sourcing nexted options in the Mapping page and referencing them in the Nested page.

* Moving tip after the introduction and clarifying limits.

* Update docs/reference/mapping.asciidoc

Co-authored-by: James Rodewig <[email protected]>

* Update docs/reference/mapping/types/nested.asciidoc

Co-authored-by: James Rodewig <[email protected]>

Co-authored-by: James Rodewig <[email protected]>
lockewritesdocs pushed a commit to lockewritesdocs/elasticsearch that referenced this issue May 19, 2020
@jrodewig
[DOCS] Add links to flattened datatype (elastic#56794)
f8ca2ec 
* Changes for elastic#52239.

* Incorporating review feedback from Julie T. Also single-sourcing nexted options in the Mapping page and referencing them in the Nested page.

* Moving tip after the introduction and clarifying limits.

* Update docs/reference/mapping.asciidoc

Co-authored-by: James Rodewig <[email protected]>

* Update docs/reference/mapping/types/nested.asciidoc

Co-authored-by: James Rodewig <[email protected]>

Co-authored-by: James Rodewig <[email protected]>
@lockewritesdocs lockewritesdocs mentioned this issue May 19, 2020
Merged
lockewritesdocs pushed a commit that referenced this issue May 19, 2020
@jrodewig
[DOCS] Add links to flattened datatype (#56794) (#56959)
1637f59 
* Changes for #52239.

* Incorporating review feedback from Julie T. Also single-sourcing nexted options in the Mapping page and referencing them in the Nested page.

* Moving tip after the introduction and clarifying limits.

* Update docs/reference/mapping.asciidoc

Co-authored-by: James Rodewig <[email protected]>

* Update docs/reference/mapping/types/nested.asciidoc

Co-authored-by: James Rodewig <[email protected]>

Co-authored-by: James Rodewig <[email protected]>

Co-authored-by: James Rodewig <[email protected]>
lockewritesdocs pushed a commit to lockewritesdocs/elasticsearch that referenced this issue May 19, 2020
@jrodewig
[DOCS] Add links to flattened datatype (elastic#56794)
602453f 
* Changes for elastic#52239.

* Incorporating review feedback from Julie T. Also single-sourcing nexted options in the Mapping page and referencing them in the Nested page.

* Moving tip after the introduction and clarifying limits.

* Update docs/reference/mapping.asciidoc

Co-authored-by: James Rodewig <[email protected]>

* Update docs/reference/mapping/types/nested.asciidoc

Co-authored-by: James Rodewig <[email protected]>

Co-authored-by: James Rodewig <[email protected]>
@lockewritesdocs lockewritesdocs mentioned this issue May 19, 2020
Merged
lockewritesdocs pushed a commit that referenced this issue May 19, 2020
@jrodewig
[DOCS] Add links to flattened datatype (#56794) (#56962)
8df97f6 
* Changes for #52239.

* Incorporating review feedback from Julie T. Also single-sourcing nexted options in the Mapping page and referencing them in the Nested page.

* Moving tip after the introduction and clarifying limits.

* Update docs/reference/mapping.asciidoc

Co-authored-by: James Rodewig <[email protected]>

* Update docs/reference/mapping/types/nested.asciidoc

Co-authored-by: James Rodewig <[email protected]>

Co-authored-by: James Rodewig <[email protected]>

Co-authored-by: James Rodewig <[email protected]>
lockewritesdocs pushed a commit to lockewritesdocs/elasticsearch that referenced this issue May 19, 2020
@jrodewig
[DOCS] Add links to flattened datatype (elastic#56794)
ab0e7c2 
* Changes for elastic#52239.

* Incorporating review feedback from Julie T. Also single-sourcing nexted options in the Mapping page and referencing them in the Nested page.

* Moving tip after the introduction and clarifying limits.

* Update docs/reference/mapping.asciidoc

Co-authored-by: James Rodewig <[email protected]>

* Update docs/reference/mapping/types/nested.asciidoc

Co-authored-by: James Rodewig <[email protected]>

Co-authored-by: James Rodewig <[email protected]>
@lockewritesdocs lockewritesdocs mentioned this issue May 19, 2020
Merged
lockewritesdocs pushed a commit that referenced this issue May 19, 2020
@jrodewig
[DOCS] Add links to flattened datatype (#56794) (#56963)
cbd35e9 
* Changes for #52239.

* Incorporating review feedback from Julie T. Also single-sourcing nexted options in the Mapping page and referencing them in the Nested page.

* Moving tip after the introduction and clarifying limits.

* Update docs/reference/mapping.asciidoc

Co-authored-by: James Rodewig <[email protected]>

* Update docs/reference/mapping/types/nested.asciidoc

Co-authored-by: James Rodewig <[email protected]>

Co-authored-by: James Rodewig <[email protected]>

Co-authored-by: James Rodewig <[email protected]>
@javanna javanna added Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch and removed Team:Search Meta label for search team labels Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lockewritesdocs lockewritesdocs

Labels
>docs General docs changes :Search Foundations/Mapping Index mappings, including merging and defining field types Team:Docs Meta label for docs team Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[DOCS] Add links to flattened datatype lockewritesdocs/elasticsearch
6 participants
@rjernst @jpountz @javanna @elasticmachine @lockewritesdocs @jrodewig