Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Transform] add support for extended_stats and string_stats aggregations #51925

Open
hendrikmuhs opened this issue Feb 5, 2020 · 4 comments
Open

[Transform] add support for extended_stats and string_stats aggregations #51925

hendrikmuhs opened this issue Feb 5, 2020 · 4 comments
Labels
>enhancement help wanted adoptme :ml/Transform Transform

Comments

@hendrikmuhs
Copy link

hendrikmuhs commented Feb 5, 2020 •
edited
Loading

#51808 added the groundwork for multi value aggregations in general and added percentiles support.

More multi value aggregations should be supported:

  • stats
  • extended stats
  • string stats
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core (:ml/Transform)

@hendrikmuhs hendrikmuhs added the help wanted adoptme label Feb 13, 2020
@hendrikmuhs hendrikmuhs mentioned this issue Apr 23, 2021
Merged
@hendrikmuhs
Copy link
Author

Stats got added in #71850

@hendrikmuhs hendrikmuhs changed the title [Transform] add support for stats, extended_stats and string_stats aggregations [Transform] add support for extended_stats and string_stats aggregations Apr 23, 2021
hendrikmuhs pushed a commit that referenced this issue Apr 27, 2021
[Transform] add support for top metrics (#71850)
7fff5df 
add support for the stats and top metrics aggregation in transform. With this change it became
easier to add more multi value aggregations to transform

Limitations:
 - only the 1st element of top_metrics gets consumed by transform[*].
 - all values of stats will be mapped to double if mapping deduction is used, including count,
   sum, min, max

fixes #52236
relates #51925
@hendrikmuhs hendrikmuhs mentioned this issue Apr 27, 2021
Merged
hendrikmuhs pushed a commit that referenced this issue Apr 27, 2021
[7.x][Transform] add support for top metrics (#72311)
6175b6d 
add support for the stats and top metrics aggregation in transform. With this change it became
easier to add more multi value aggregations to transform

Limitations:
 - only the 1st element of top_metrics gets consumed by transform[*].
 - all values of stats will be mapped to double if mapping deduction is used, including count,
   sum, min, max

fixes #52236
relates #51925
@Kiriakos1998
Copy link
Contributor

Hello @hendrikmuhs , is this issue still open so I may work on it? Also if it's still open do you suggest opening two PRs for each aggregation or one for both of them?

@hendrikmuhs
Copy link
Author

@Kiriakos1998 Either way, 1 combined or 2 separate PR's, works. Have a look at #71850 to see how it works, it should be relatively easy to add support for both. The main work is writing good tests.

prwhelan added a commit to prwhelan/elasticsearch that referenced this issue Jan 17, 2025
@prwhelan
[Transform] add support for extended_stats
44eecfe 
Building off of `stats` and multi-value aggregations, including the
limitation:
- all values of extended_stats will be mapped to `double` if mapping
  deduction is used

Relates elastic#51925
@prwhelan prwhelan mentioned this issue Jan 17, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
>enhancement help wanted adoptme :ml/Transform Transform
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hendrikmuhs @elasticmachine @Kiriakos1998