Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] LoggingOutputStreamTests fails on Windows #51532

Closed
droberts195 opened this issue Jan 28, 2020 · 4 comments · Fixed by #51779
Closed

[CI] LoggingOutputStreamTests fails on Windows #51532

droberts195 opened this issue Jan 28, 2020 · 4 comments · Fixed by #51779
Assignees
@rjernst
Labels
:Core/Infra/Logging Log management and logging utilities >test-failure Triaged test failures from CI

Comments

@droberts195
Copy link
Contributor

The following tests fail in 7.x Windows builds:

org.elasticsearch.common.logging.LoggingOutputStreamTests testBufferExtension
org.elasticsearch.common.logging.LoggingOutputStreamTests testEmptyLine
org.elasticsearch.common.logging.LoggingOutputStreamTests testFlushOnNewline
org.elasticsearch.common.logging.LoggingOutputStreamTests testMaxBuffer
org.elasticsearch.common.logging.LoggingOutputStreamTests testThreadIsolation

An example is https://gradle-enterprise.elastic.co/s/yiooghd5t4ai4 (but every 7.x Windows build is failing for this reason).

The errors are all along the lines of this:

Expected: iterable containing ["pjsQsvUyoViFJjlUeCGSsMwFyERKKNZexDFEkobYKBmMuiqRUjqKIGjFAIojNnJgIZAqCaewZeaiaIqRupTDLXQhPmAdaRTzNPLYypRYxiVeZQOycAVicOazPvUQifDNMOqaXIJJRAOrlndMd", "OVERFLOW"]
     but: item 1: was "\r"

It seems like the CRLF Windows line endings are messing up the line splitting.
@droberts195 droberts195 added >test-failure Triaged test failures from CI :Core/Infra/Logging Log management and logging utilities labels Jan 28, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (:Core/Infra/Logging)

@droberts195
Copy link
Contributor Author

Unsurprisingly these same tests are also failing for the same reason on Windows on master. They just didn't appear in the failure emails for master because so many other tests are also failing on Windows...

@cbuescher
Copy link
Member

Several more of this today, e.g. https://gradle-enterprise.elastic.co/s/727tjb7hppge4 on 7.x or https://gradle-enterprise.elastic.co/s/pxnzjqw65ckj2 on master.

@mayya-sharipova
Copy link
Contributor

Several more of these failures today on master:
The latest:

Log: https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+master+multijob-windows-compatibility/os=windows-2016/418/console
Build Scans: https://gradle-enterprise.elastic.co/s/63vvoouwnqwto

rjernst added a commit to rjernst/elasticsearch that referenced this issue Jan 31, 2020
@rjernst
Fix LoggingOutputStream to work on windows
1f7f016 
LoggingOutputStream reads a stream and breaks on newlines. This commit
fixes the behavior to account for windows newlines also containing `\r`.

closes elastic#51532
@rjernst rjernst mentioned this issue Jan 31, 2020
Merged
rjernst added a commit that referenced this issue Feb 1, 2020
@rjernst
Fix LoggingOutputStream to work on windows (#51779)
7f0608d 
LoggingOutputStream reads a stream and breaks on newlines. This commit
fixes the behavior to account for windows newlines also containing `\r`.

closes #51532
rjernst added a commit that referenced this issue Feb 1, 2020
@rjernst
Fix LoggingOutputStream to work on windows (#51779)
61622c4 
LoggingOutputStream reads a stream and breaks on newlines. This commit
fixes the behavior to account for windows newlines also containing `\r`.

closes #51532
@codebrain codebrain mentioned this issue Apr 1, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rjernst rjernst

Labels
:Core/Infra/Logging Log management and logging utilities >test-failure Triaged test failures from CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix LoggingOutputStream to work on windows rjernst/elasticsearch
5 participants
@rjernst @mayya-sharipova @droberts195 @cbuescher @elasticmachine