ScriptBytesValues.currentValueHash is wrong #5004
Assignees
Labels
Comments
|
Damned! good catch |
|
|
jpountz
added a commit
to jpountz/elasticsearch
that referenced
this issue
Feb 4, 2014
This commit removes FilterBytesValues which is very trappy as the default implementation forwards all method calls to the delegate. So if you do any non-trivial modification to the terms or to the order of the terms, you need to remember to override currentValueHash, copyShared, and this is very error-prone. FieldDataSource.WithScript.BytesValues and ScriptBytesValues now return correct hash codes, future bugs here would be catched by the new assertion in SortedUniqueBytesValues. This bug was causing performance issues with scripts as all terms were assumed to have the same hash code. Close elastic#5004
jpountz
added a commit
that referenced
this issue
Feb 4, 2014
This commit removes FilterBytesValues which is very trappy as the default implementation forwards all method calls to the delegate. So if you do any non-trivial modification to the terms or to the order of the terms, you need to remember to override currentValueHash, copyShared, and this is very error-prone. FieldDataSource.WithScript.BytesValues and ScriptBytesValues now return correct hash codes, future bugs here would be catched by the new assertion in SortedUniqueBytesValues. This bug was causing performance issues with scripts as all terms were assumed to have the same hash code. Close #5004
jpountz
added a commit
that referenced
this issue
Feb 4, 2014
This commit removes FilterBytesValues which is very trappy as the default implementation forwards all method calls to the delegate. So if you do any non-trivial modification to the terms or to the order of the terms, you need to remember to override currentValueHash, copyShared, and this is very error-prone. FieldDataSource.WithScript.BytesValues and ScriptBytesValues now return correct hash codes, future bugs here would be catched by the new assertion in SortedUniqueBytesValues. This bug was causing performance issues with scripts as all terms were assumed to have the same hash code. Close #5004
mute
pushed a commit
to mute/elasticsearch
that referenced
this issue
Jul 29, 2015
This commit removes FilterBytesValues which is very trappy as the default implementation forwards all method calls to the delegate. So if you do any non-trivial modification to the terms or to the order of the terms, you need to remember to override currentValueHash, copyShared, and this is very error-prone. FieldDataSource.WithScript.BytesValues and ScriptBytesValues now return correct hash codes, future bugs here would be catched by the new assertion in SortedUniqueBytesValues. This bug was causing performance issues with scripts as all terms were assumed to have the same hash code. Close elastic#5004
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ScriptBytesValues.currentValueHashdoesn't return the hash value of the last returned term. The reason is that it has its ownBytesRef(ScriptDocValues.scratch) to store the term while the hash code is computed on the parent's term (BytesValues.scratch).The text was updated successfully, but these errors were encountered: