es.http.cname_in_publish_address deprecation warning emitted even if not set #47436
Comments
DaveCTurner
added
>bug
:Distributed Coordination/Network
|
Pinging @elastic/es-distributed (:Distributed/Network) |
Since the property defaulted to `true` this deprecation logging runs every time unless its set to `false` manually (in which case it should've also logged but didn't). Closes elastic#47436
Since the property defaulted to `true` this deprecation logging
runs every time unless its set to `false` manually (in which case
it should've also logged but didn't).
I didn't add a tests and removed the tests we had in `7.x` that
covered this logging. I did move the check out of the `if (InetAddresses.isInetAddress(hostString) == false) {` condition so this is sort-of covered by the REST tests.
IMO, any unit-test of this would be somewhat redundant and would've forced
adding a field that just indicates that the deprecated property was used to
every instance which seemed pointless.
Closes #47436
Since the property defaulted to `true` this deprecation logging
runs every time unless its set to `false` manually (in which case
it should've also logged but didn't).
I didn't add a tests and removed the tests we had in `7.x` that
covered this logging. I did move the check out of the `if (InetAddresses.isInetAddress(hostString) == false) {` condition so this is sort-of covered by the REST tests.
IMO, any unit-test of this would be somewhat redundant and would've forced
adding a field that just indicates that the deprecated property was used to
every instance which seemed pointless.
Closes elastic#47436
…7497) Since the property defaulted to `true` this deprecation logging runs every time unless its set to `false` manually (in which case it should've also logged but didn't). I didn't add a tests and removed the tests we had in `7.x` that covered this logging. I did move the check out of the `if (InetAddresses.isInetAddress(hostString) == false) {` condition so this is sort-of covered by the REST tests. IMO, any unit-test of this would be somewhat redundant and would've forced adding a field that just indicates that the deprecated property was used to every instance which seemed pointless. Closes #47436
|
Hi! Is this really fixed? We just updated to 7.4.2 from 7.4.0 but still see multiple messages like this per second in our deprecation log even if we don't have this property set in our elasticsearch.yml Greetings, |
|
@baunz that property should be (if it's set) in your |
|
I have the same issue with 7.4.2, and I'm sure I don't set es.http.cname_in_publish_address property. |
|
@jockjiang could you check the nodes stats API to check the actual JVM options used by your node(s)? If the system property is still in there, it's being picked up from somewhere in your system. It seems unlikely that this is still not fixed in |
|
@original-brownbear , I attached the result from the API. please review. I find "-Des.http.cname_in_publish_address=true" in the JVM options. |
|
@jockjiang yea so this really looks like you have the option set in your configs. Probably in the |
In #45616 we added a deprecation warning to encourage users to remove the
es.http.cname_in_publish_addressproperty that we added to support BWC across a 6.x/7.x upgrade. However this warning is emitted wheneveres.http.cname_in_publish_addressis true, which is the default, so it's emitted even if the property is unset.Relates https://discuss.elastic.co/t/deprecation-warnings-since-the-upgrade-to-7-4-0/201917/3
The text was updated successfully, but these errors were encountered: