Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Question\Sugestion] Support WKT point conversion to geo_point type #41821

Closed
4nonym0us opened this issue May 5, 2019 · 4 comments · Fixed by #44107
Closed

[Question\Sugestion] Support WKT point conversion to geo_point type #41821

4nonym0us opened this issue May 5, 2019 · 4 comments · Fixed by #44107
Assignees
@imotov
Labels
:Analytics/Geo Indexing, search aggregations of geo points and shapes

Comments

@4nonym0us
Copy link

Having WKT POINT support only for geo_shape and not for geo_point is a bit confusing because WKT specification has GeoPoint representation.

Would't it be good to have an option to use WKT's point syntax POINT (X, Y) for geo_point for consistency as support even for more complex WKT primitives and multipart geometries is already present for geo_shape?
@dnhatn dnhatn added the :Analytics/Geo Indexing, search aggregations of geo points and shapes label May 5, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo

@imotov imotov self-assigned this May 9, 2019
@Hohol
Copy link
Contributor

Hohol commented Jul 8, 2019

I'm working on this issue.
@imotov, geo_point field can actually contain an array of geo_point.
Does it mean we need to support something like WKT's MULTIPOINT? Or simply supporting POINT is enough?

@imotov
Copy link
Contributor

imotov commented Jul 8, 2019

@Hohol I think just point should be enough to start with. If you use WellKnownText parser, you can try parsing the string as WKT and then throw an exception if it is not a Point. We can expand it later to MultiPoints and other geometries if there is a need.

@Hohol Hohol mentioned this issue Jul 9, 2019
Merged
@Hohol
Copy link
Contributor

Hohol commented Jul 9, 2019

@imotov, PR is ready for review
#44107

imotov pushed a commit that referenced this issue Jul 12, 2019
@Hohol @imotov
Support WKT point conversion to geo_point type (#44107)
a851992 
This PR adds support for parsing geo_point values from WKT POINT format.
Also, a few minor bugs in geo_point parsing were fixed.

Closes #41821
imotov pushed a commit that referenced this issue Jul 12, 2019
@Hohol @imotov
Support WKT point conversion to geo_point type (#44107)
d187fcb 
This PR adds support for parsing geo_point values from WKT POINT format.
Also, a few minor bugs in geo_point parsing were fixed.

Closes #41821
@codebrain codebrain mentioned this issue Oct 14, 2019
Closed
56 tasks
@codebrain codebrain mentioned this issue Oct 23, 2019
Closed
39 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@imotov imotov

Labels
:Analytics/Geo Indexing, search aggregations of geo points and shapes
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support WKT point conversion to geo_point type
5 participants
@imotov @4nonym0us @Hohol @dnhatn @elasticmachine