Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SQL: IP fields tests #40358

Closed
astefan opened this issue Mar 22, 2019 · 1 comment · Fixed by #40384
Closed

SQL: IP fields tests #40358

astefan opened this issue Mar 22, 2019 · 1 comment · Fixed by #40384
Assignees
@costin
Labels
:Analytics/SQL SQL querying

Comments

@astefan
Copy link
Contributor

astefan commented Mar 22, 2019

At the moment, the IP fields CSV tests are not enabled: https://github.com/elastic/elasticsearch/pull/40354/files#diff-37c99935a11f8b50577997cfa35e284bR47

Would be good to enable them and have a look at the tests.
@astefan astefan added the :Analytics/SQL SQL querying label Mar 22, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search

@costin costin mentioned this issue Mar 22, 2019
Merged
costin added a commit to costin/elasticsearch that referenced this issue Mar 23, 2019
@costin
SQL: Add missing handling of IP field in JDBC
c64c14a 
Fix elastic#40358
costin added a commit that referenced this issue Mar 23, 2019
@costin
SQL: Add missing handling of IP field in JDBC (#40384)
ee286fa 
Fix #40358
@costin costin mentioned this issue Mar 23, 2019
Merged
costin added a commit that referenced this issue Mar 23, 2019
@costin
SQL: Add missing handling of IP field in JDBC (#40384)
558adc0 
Fix #40358

(cherry picked from commit ee286fa)
(cherry picked from commit d229624)
costin added a commit that referenced this issue Mar 23, 2019
@costin
SQL: Add missing handling of IP field in JDBC (#40384)
daf97ce 
Fix #40358

(cherry picked from commit ee286fa)
(cherry picked from commit d229624)
costin added a commit that referenced this issue Mar 23, 2019
@costin
SQL: Add missing handling of IP field in JDBC (#40384)
8ea08df 
Fix #40358

(cherry picked from commit ee286fa)
(cherry picked from commit d229624)
costin added a commit to costin/elasticsearch that referenced this issue Mar 23, 2019
@costin
SQL: Spec tests now use classpath discovery
8238017 
To avoid having to specify each spec by hand (which can miss specs to be
added), the test infrastructure now performs classpath discovery so that
each spec added, is automatically considered.

Relates elastic#40358
costin added a commit that referenced this issue Mar 25, 2019
@costin
SQL: Spec tests now use classpath discovery (#40388)
d0f60b4 
To avoid having to specify each spec by hand (which can miss specs to be
added), the test infrastructure now performs classpath discovery so that
each spec added, is automatically considered.

Relates #40358
costin added a commit that referenced this issue Mar 25, 2019
@costin
SQL: Spec tests now use classpath discovery (#40388)
61f49af 
To avoid having to specify each spec by hand (which can miss specs to be
added), the test infrastructure now performs classpath discovery so that
each spec added, is automatically considered.

Relates #40358

(cherry picked from commit d0f60b4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@costin costin

Labels
:Analytics/SQL SQL querying
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

SQL: Add missing handling of IP field in JDBC costin/elasticsearch
3 participants
@costin @astefan @elasticmachine