Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SQL: Fix esType for DATETIME/DATE and INTERVALS #38051

Closed
matriv opened this issue Jan 30, 2019 · 1 comment
Closed

SQL: Fix esType for DATETIME/DATE and INTERVALS #38051

matriv opened this issue Jan 30, 2019 · 1 comment
Assignees
@matriv
Labels
:Analytics/SQL SQL querying >bug v6.7.0 v7.0.0-beta1

Comments

@matriv
Copy link
Contributor

matriv commented Jan 30, 2019

Currently esType is just a lowercase of the DataType.
Since esType is used for calls to unmappedType() this must be fixed, as for DATETIME it should be date and for ES-SQL types only like DATE and INTERVAL types it should be unsupported operation.
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search

@matriv matriv self-assigned this Jan 30, 2019
matriv added a commit to matriv/elasticsearch that referenced this issue Feb 1, 2019
@matriv
SQL: Fix esType for DATETIME/DATE and INTERVALS
5c7ff99 
Since introduction of data types that don't have a corresponding type
in ES the `esType` is error-prone when used for `unmappedType()` calls.
Moreover since the renaming of `DATE` to `DATETIME` and the introduction
of an actual date-only `DATE` the `esType` would return `datetime` which
is not a valid type for ES mapping.

Fixes: elastic#38051
@matriv matriv mentioned this issue Feb 1, 2019
Merged
matriv added a commit that referenced this issue Feb 5, 2019
@matriv
SQL: Fix esType for DATETIME/DATE and INTERVALS (#38179)
2c30501 
Since introduction of data types that don't have a corresponding type
in ES the `esType` is error-prone when used for `unmappedType()` calls.
Moreover since the renaming of `DATE` to `DATETIME` and the introduction
of an actual date-only `DATE` the `esType` would return `datetime` which
is not a valid type for ES mapping.

Fixes: #38051
matriv added a commit that referenced this issue Feb 5, 2019
@matriv
SQL: Fix esType for DATETIME/DATE and INTERVALS (#38179)
46cca7f 
Since introduction of data types that don't have a corresponding type
in ES the `esType` is error-prone when used for `unmappedType()` calls.
Moreover since the renaming of `DATE` to `DATETIME` and the introduction
of an actual date-only `DATE` the `esType` would return `datetime` which
is not a valid type for ES mapping.

Fixes: #38051
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matriv matriv

Labels
:Analytics/SQL SQL querying >bug v6.7.0 v7.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@colings86 @matriv @elasticmachine