Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use TestFixturesPlugin to Spin up Minio in S3 Plugin Tests #37783

Closed
original-brownbear opened this issue Jan 23, 2019 · 1 comment
Closed

Use TestFixturesPlugin to Spin up Minio in S3 Plugin Tests #37783

original-brownbear opened this issue Jan 23, 2019 · 1 comment
Assignees
@original-brownbear
Labels
:Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs >test Issues or PRs that are addressing/adding tests

Comments

@original-brownbear
Copy link
Member

From #37680 (comment)

Instead of keeping a bunch of complicated logic for finding a free port for Minio and retrying starting it from #37747 around, we should move these tests to using the TestFixturesPlugin for spinning up Minio like we do for SMB.

FYI @atorok
@original-brownbear original-brownbear added >test Issues or PRs that are addressing/adding tests :Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs labels Jan 23, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed

@original-brownbear original-brownbear mentioned this issue Jan 23, 2019
Merged
@original-brownbear original-brownbear self-assigned this Jan 24, 2019
This was referenced Jan 24, 2019
Merged
Closed
original-brownbear added a commit to original-brownbear/elasticsearch that referenced this issue Jan 25, 2019
@original-brownbear
Use TestFixturesPlugin to Run Minio in Tests
9374555 
* Closes elastic#37680
* Closes elastic#37783
@original-brownbear original-brownbear mentioned this issue Jan 25, 2019
Merged
original-brownbear added a commit that referenced this issue Jan 25, 2019
@original-brownbear
Use TestFixturesPlugin to Run Minio in Tests (#37852)
be6bdab 
* Use TestFixturesPlugin to Run Minio in Tests

* Closes #37680
* Closes #37783
original-brownbear added a commit to original-brownbear/elasticsearch that referenced this issue Jan 29, 2019
@original-brownbear
Use TestFixturesPlugin to Run Minio in Tests (elastic#37852)
7c86db0 
* Use TestFixturesPlugin to Run Minio in Tests

* Closes elastic#37680
* Closes elastic#37783
@original-brownbear original-brownbear mentioned this issue Jan 29, 2019
Merged
original-brownbear added a commit that referenced this issue Jan 29, 2019
@original-brownbear
Use TestFixturesPlugin to Run Minio in Tests (#37852) (#37983)
4b6678f 
* Use TestFixturesPlugin to Run Minio in Tests

* Closes #37680
* Closes #37783
@talevy talevy mentioned this issue Feb 15, 2019
Merged
talevy pushed a commit to talevy/elasticsearch that referenced this issue Feb 15, 2019
@original-brownbear @talevy
Use TestFixturesPlugin to Run Minio in Tests (elastic#37852)
6fb6847 
* Use TestFixturesPlugin to Run Minio in Tests

* Closes elastic#37680
* Closes elastic#37783
talevy added a commit that referenced this issue Mar 11, 2019
@talevy
Use TestFixturesPlugin to Run Minio in Tests (#37852) (#38973)
8127693 
* Use TestFixturesPlugin to Run Minio in Tests  (#37852)

* Use TestFixturesPlugin to Run Minio in Tests

* Closes #37680
* Closes #37783

* Fix S3 Repository ITs When Docker is not Available (#37878)

* Disable Minio fixture and tests that require it when fixtures are disabled or Docker is not available
* Relates #37852

* add explicit composeUp dependsOn
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@original-brownbear original-brownbear

Labels
:Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs >test Issues or PRs that are addressing/adding tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@original-brownbear @elasticmachine