SimpleQueryStringBuilderTests fails on 6.x

[javanna]

Recent failures: https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+6.x+intake/239/ and https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+6.x+multijob-unix-compatibility/os=oraclelinux/71/console .

11:11:34 FAILURE 0.01s J4 | SimpleQueryStringBuilderTests.testUnmappedFieldNoTokenWithAndOperator <<< FAILURES!
11:11:34    > Throwable #1: java.lang.AssertionError: expected:<+mapped_string:first +mapped_string:second> but was:<MatchNoDocsQuery("empty string passed to query parser")>
11:11:34    > 	at __randomizedtesting.SeedInfo.seed([9937D8E57DE82F56:A3EFDB46BCC88FD2]:0)
11:11:34    > 	at org.elasticsearch.index.query.SimpleQueryStringBuilderTests.testUnmappedFieldNoTokenWithAndOperator(SimpleQueryStringBuilderTests.java:727)
11:11:34    > 	at java.lang.Thread.run(Thread.java:748)

FAILURE 1.79s | SimpleQueryStringBuilderTests.testToQuery <<< FAILURES!
   > Throwable #1: java.lang.AssertionError: 
   > Expected: an instance of org.apache.lucene.search.DisjunctionMaxQuery
   >      but: <MatchNoDocsQuery("empty string passed to query parser")> is a org.apache.lucene.search.MatchNoDocsQuery
   >    at __randomizedtesting.SeedInfo.seed([C7621377DC53D26C:30991149ADD01786]:0)
   >    at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
   >    at org.elasticsearch.index.query.SimpleQueryStringBuilderTests.doAssertLuceneQuery(SimpleQueryStringBuilderTests.java:278)
   >    at org.elasticsearch.index.query.SimpleQueryStringBuilderTests.doAssertLuceneQuery(SimpleQueryStringBuilderTests.java:67)
   >    at org.elasticsearch.test.AbstractQueryTestCase.assertLuceneQuery(AbstractQueryTestCase.java:522)
   >    at org.elasticsearch.test.AbstractQueryTestCase.testToQuery(AbstractQueryTestCase.java:436)
   >    at java.lang.Thread.run(Thread.java:748)

Reproduce lines (they both reproduce for me):

./gradlew :server:test -Dtests.seed=9937D8E57DE82F56 -Dtests.class=org.elasticsearch.index.query.SimpleQueryStringBuilderTests -Dtests.method="testUnmappedFieldNoTokenWithAndOperator" -Dtests.security.manager=true -Dtests.locale=sr-RS -Dtests.timezone=America/Argentina/Salta -Dcompiler.java=11 -Druntime.java=8

./gradlew :server:test \
  -Dtests.seed=C7621377DC53D26C \
  -Dtests.class=org.elasticsearch.index.query.SimpleQueryStringBuilderTests \
  -Dtests.method="testToQuery" \
  -Dtests.security.manager=true \
  -Dtests.locale=fr-FR \
  -Dtests.timezone=Asia/Gaza \
  -Dcompiler.java=11 \
  -Druntime.java=8

I suspect this is due to 92331fd .

[elasticmachine]

Pinging @elastic/es-search

[javanna]

I muted this test as it is failing quite frequently on 6.x.

[cbuescher]

SimpleQueryStringBuilderTests.testUnmappedFieldNoTokenWithAndOperator <<< FAILURES

This happens when we don't register any types, which doesn't happen any more on 7.0 because of types removal. I will add an assumeTrue like we have in other tests here.

SimpleQueryStringBuilderTests.testToQuery <<< FAILURES!

This one is also related to no types being present in conjunction with a selection of more than one field. We used to build DisjunctionMaxQuerys containing only MatchNoDocsQuery on these cases, but we only build one MatchNoDocsQuery now. Will update the assumptions in the tests here.

[cbuescher]

I pushed 48f9c0d with a fix.