Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IndicesRequestIT#testBulk fails with NullPointerException #32808

Closed
dnhatn opened this issue Aug 13, 2018 · 2 comments
Closed

IndicesRequestIT#testBulk fails with NullPointerException #32808

dnhatn opened this issue Aug 13, 2018 · 2 comments
Labels
:Distributed Indexing/CRUD A catch all label for issues around indexing, updating and getting a doc by id. Not search. >test-failure Triaged test failures from CI

Comments

@dnhatn
Copy link
Member

dnhatn commented Aug 13, 2018

This suite started failing since August 10th. May be related to #31821?

ERROR   0.57s J0 | IndicesRequestIT.testBulk <<< FAILURES!
   > Throwable #1: java.lang.NullPointerException
   > 	at org.elasticsearch.action.bulk.BulkItemRequest.index(BulkItemRequest.java:56)
   > 	at org.elasticsearch.action.bulk.BulkShardRequest.indices(BulkShardRequest.java:54)
   > 	at org.elasticsearch.action.IndicesRequestIT.assertIndicesSubset(IndicesRequestIT.java:626)
   > 	at org.elasticsearch.action.IndicesRequestIT.testBulk(IndicesRequestIT.java:315)
   > 	at java.lang.Thread.run(Thread.java:748)Throwable #2: java.lang.AssertionError: 
   > Expected: an empty iterable
   >      but: [<indices:data/write/bulk[s][r]=[ConcreteReplicaRequest{targetAllocationID='tPWE26HSR9yG-ukYI_I5AQ', primaryTerm='1', request=BulkShardRequest [[test0][0]] containing [4] requests, globalCheckpoint=-1}]>]
   > 	at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
   > 	at org.elasticsearch.action.IndicesRequestIT.assertAllRequestsHaveBeenConsumed(IndicesRequestIT.java:686)
   > 	at org.elasticsearch.action.IndicesRequestIT.cleanUp(IndicesRequestIT.java:177)
   > 	at java.lang.Thread.run(Thread.java:748)

I can reproduce this locally around 10%.

./gradlew :server:integTest   
-Dtests.seed=3F68AD9A997FF672   
-Dtests.class=org.elasticsearch.action.IndicesRequestIT   
-Dtests.method="testBulk"   
-Dtests.security.manager=true  
-Dtests.locale=it-CH   
-Dtests.timezone=America/Dawson_Creek  
-Dcompiler.java=10   
-Druntime.java=8

Some instances:
@dnhatn dnhatn added :Distributed Indexing/CRUD A catch all label for issues around indexing, updating and getting a doc by id. Not search. >test-failure Triaged test failures from CI labels Aug 13, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed

dnhatn added a commit that referenced this issue Aug 13, 2018
@dnhatn
Mute IndicesRequestIT#testBulk
cb2273b 
Tracked at #32808
dnhatn added a commit that referenced this issue Aug 13, 2018
@dnhatn
Mute IndicesRequestIT#testBulk
1009581 
Tracked at #32808
@dnhatn
Copy link
Member Author

dnhatn commented Aug 13, 2018

I've muted this test on master and 6.x

@ywelsch ywelsch mentioned this issue Aug 13, 2018
Merged
ywelsch added a commit that referenced this issue Aug 14, 2018
@ywelsch
Fix NOOP bulk updates (#32819)
a8bfa46 
#31821 introduced an unreleased bug where NOOP updates were incorrectly mutating the bulk
shard request, inserting null item to be replicated, which would result in NullPointerExceptions when
serializing the request to be shipped to the replicas.

Closes #32808
ywelsch added a commit that referenced this issue Aug 14, 2018
@ywelsch
Fix NOOP bulk updates (#32819)
5f656d7 
#31821 introduced an unreleased bug where NOOP updates were incorrectly mutating the bulk
shard request, inserting null item to be replicated, which would result in NullPointerExceptions when
serializing the request to be shipped to the replicas.

Closes #32808
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
:Distributed Indexing/CRUD A catch all label for issues around indexing, updating and getting a doc by id. Not search. >test-failure Triaged test failures from CI
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dnhatn @elasticmachine