Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SQL: Equality should use == instead of = #31796

Closed
astefan opened this issue Jul 4, 2018 · 1 comment
Closed

SQL: Equality should use == instead of = #31796

astefan opened this issue Jul 4, 2018 · 1 comment
Labels
:Analytics/SQL SQL querying >bug v7.0.0-beta1

Comments

@astefan
Copy link
Contributor

astefan commented Jul 4, 2018

SQL has = as valid symbol for equality, but Painless scripts use ==. Currently, ES SQL uses = for Painless scripting which is incorrect.
@astefan astefan added >bug :Analytics/SQL SQL querying labels Jul 4, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search-aggs

@costin costin added the v7.0.0 label Jul 5, 2018
costin added a commit to costin/elasticsearch that referenced this issue Jul 5, 2018
@costin
SQL: Fix incorrect HAVING equality
17ce542 
Fix bug that causes `HAVING a = b` to be translated ad-litteram in
Painless which uses `==` for equality checks not `=`.

Close elastic#31796
@costin costin mentioned this issue Jul 5, 2018
Merged
costin added a commit that referenced this issue Jul 6, 2018
@costin
SQL: Fix incorrect HAVING equality (#31820)
89cb087 
Fix bug that causes `HAVING a = b` to be translated ad-litteram in
Painless which uses `==` for equality checks not `=`.

Close #31796
costin added a commit that referenced this issue Jul 6, 2018
@costin
SQL: Fix incorrect HAVING equality (#31820)
32746fd 
Fix bug that causes `HAVING a = b` to be translated ad-litteram in
Painless which uses `==` for equality checks not `=`.

Close #31796

(cherry picked from commit 89cb087)
costin added a commit that referenced this issue Jul 6, 2018
@costin
SQL: Fix incorrect HAVING equality (#31820)
81ea7bf 
Fix bug that causes `HAVING a = b` to be translated ad-litteram in
Painless which uses `==` for equality checks not `=`.

Close #31796

(cherry picked from commit 89cb087)
(cherry picked from commit 32746fd)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
:Analytics/SQL SQL querying >bug v7.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@costin @colings86 @astefan @elasticmachine