Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FVH produces StringArrayIndexOutOfBounds if stored field is used #3140

Closed
s1monw opened this issue Jun 6, 2013 · 0 comments
Closed

FVH produces StringArrayIndexOutOfBounds if stored field is used #3140

s1monw opened this issue Jun 6, 2013 · 0 comments
Assignees
@s1monw
Labels
>bug v0.90.2 v1.0.0.Beta1

Comments

@s1monw
Copy link
Contributor

s1monw commented Jun 6, 2013

We still use Lucene's SimpleFragmentsBuilder which doesn't try to correct the offsets is a broken analysis chain is used like the old NGramTokenFilter. SimpleFragmentsBuilder also needs to call into FragmentBuilderHelper.fixWeightedFragInfo() to detect broken chains and do best effort to resort the tokens.
@ghost ghost assigned s1monw Jun 6, 2013
@s1monw s1monw closed this as completed in f995c9c Jun 6, 2013
s1monw added a commit that referenced this issue Jun 6, 2013
@s1monw
Correct offsets in FVH also if stored field is used for highlighting
6dc9579 
The SimpleFragemntsBuilder did not correct offsets if the used
analysis chais could produce broken offsets that could lead to
StringArrayIndexOutOfBounds Exceptions

Closes #3140
mute pushed a commit to mute/elasticsearch that referenced this issue Jul 29, 2015
@s1monw
Correct offsets in FVH also if stored field is used for highlighting
5171ba2 
The SimpleFragemntsBuilder did not correct offsets if the used
analysis chais could produce broken offsets that could lead to
StringArrayIndexOutOfBounds Exceptions

Closes elastic#3140
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@s1monw s1monw

Labels
>bug v0.90.2 v1.0.0.Beta1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@s1monw