Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FollowingEngine shouldn't fill history gaps upon promotion and recovery #31318

Closed
bleskes opened this issue Jun 14, 2018 · 3 comments
Closed

FollowingEngine shouldn't fill history gaps upon promotion and recovery #31318

bleskes opened this issue Jun 14, 2018 · 3 comments
Labels
:Distributed Indexing/CCR Issues around the Cross Cluster State Replication features

Comments

@bleskes
Copy link
Contributor

bleskes commented Jun 14, 2018 •
edited
Loading

The following engine doesn't own the history but rather follows a remote one. As such, it can not close gaps on its own.

/cc @martijnvg @jasontedor
@bleskes bleskes added the :Distributed Indexing/CCR Issues around the Cross Cluster State Replication features label Jun 14, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed

@elasticmachine elasticmachine mentioned this issue Jun 21, 2018
Closed
29 tasks
@martijnvg
Copy link
Member

Gaps are closed in: Engine#fillSeqNoGaps(...)

I talked about this with @bleskes and he said the easiest way to achieve this is by making the fillSeqNoGaps(...) method a noop in the FollowingEngine implementation. Besides the unit test on the engine level, it would be good to have a test that simulates the need for this.

martijnvg added a commit to martijnvg/elasticsearch that referenced this issue Jul 3, 2018
@martijnvg
Follow engine should not fill gaps upon promotion and recovery.
8597ac0 
Closes elastic#31318
@martijnvg martijnvg mentioned this issue Jul 3, 2018
Merged
martijnvg added a commit that referenced this issue Jul 3, 2018
@martijnvg
Follow engine should not fill gaps upon promotion and recovery (#31751)
ac654cb 
Closes #31318
martijnvg added a commit that referenced this issue Jul 3, 2018
@martijnvg
Follow engine should not fill gaps upon promotion and recovery (#31751)
77c60df 
Closes #31318
@martijnvg
Copy link
Member

Implemented via #31751

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
:Distributed Indexing/CCR Issues around the Cross Cluster State Replication features
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@martijnvg @bleskes @elasticmachine